Bugzilla – Full Text Bug Listing
| Summary: | Changing the Syntax Coloring for Constants does a huge mess | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Sylvia Tancheva <silviya> | ||||||||||||||||
| Component: | PDT | Assignee: | Zhongwei Zhao <zhaozhongwei> | ||||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||||||
| Severity: | critical | ||||||||||||||||||
| Priority: | P1 | CC: | gadi, ganoro, ilina.s, qiangsheng.w, silviya | ||||||||||||||||
| Version: | unspecified | Flags: | ganoro:
review+
qiangsheng.w: review+ zhaozhongwei: review? (zhaozhongwei) |
||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||
| OS: | Windows XP | ||||||||||||||||||
| Whiteboard: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 177088 [details]
New screen-shot
Something similar happens when changing Normal - it looks even worse (see new screen-shot) because I accidentally changed also background color :-)
Yet I see that classes, functions, methods, constants, etc. are marked.
But background color shows that also in some places white spaces are colored as well, which I would not be able to see if I did not change the background color.
fixed in head and branch [Petyo Tanchev] Tested on 2.2.1.v20100829 About the constants - see the new attachment. define() should be colored as a function, not as a constant. The name inside the define - 'TEST' should be colored as a constant. The screen-shot is made after pressing the Apply button. About the second Silviya's issue with the NORMAL background. It is still the same. Created attachment 177715 [details]
Screen-shot 30.08.2010
About the second Silviya's issue with the NORMAL background. It is still the same.there is another bug for this Bug 323242. Created attachment 177917 [details]
patch
Created attachment 178022 [details]
patch
Created attachment 178050 [details]
patch
Created attachment 178052 [details]
patch
new patch with test file updates
+1 thanks! fixed by Zhao! Verified on Windows XP, 32 bit, with Zend Studio 9.0.0, build 179 |
Created attachment 177081 [details] screen-shot Using the same code in the Sample (bellow) - just go to Preferences -> PHP -> Editor -> Syntax Coloring -> Constants and change it (I put orange colors). Apply and OK. the result is quite astonishing - see the screen-shot <?php define ( 'TEST', "" ); echo $GLOBALS ['test']; echo __LINE__; function test($test) { return false; } /** * @deprecated */ class Foo extends ReflectionClass implements FOO\IBar { const E_ERROR = 45; var $test; public static $my_static = 'foo'; public function test($test) { return $this->test; } public static function foo() { return false; } } $text = <<<HEREDOC Hello, World! HEREDOC; /** * Sample function * @throws Exception */ function foo() { if (func_num_args () != 1) { throw new Exception ( "Illegal number of arguments" ); } // TODO: do something $args = func_get_args (); print "{$args[0]}\n"; }