Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323201

Summary:	Cannot use double-click to expand/collapse tree nodes in the 'Synchronize' view
Product:	[Technology] EGit	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Dariusz Luksza <dariusz.luksza>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, dariusz.luksza, jamesblackburn+eclipse
Version:	0.9.0
Target Milestone:	0.9.0-M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Remy Suen

2010-08-19 20:24:22 EDT

This bug is driving me crazy.

Comment 1 Remy Suen

2010-08-19 20:57:29 EDT

To fix this bug, please implement equals(Object) and hashCode() correctly in GitModelCommit and its subclasses.

hashCode() only considers 'remoteCommit' at the moment which is most certainly off.

equals(Object) is also incorrect as it does something similar by comparing a RevCommit with the target object. We should be comparing GitModelCommits with another GitModelCommit.

Comment 2 Dariusz Luksza

2010-08-20 14:00:53 EDT

Here is fix for this issue:

http://egit.eclipse.org/r/1357

Comment 3 Chris Aniszczyk

2010-08-20 18:52:57 EDT

Fixed with 7d7525e8413a314f2a0dfa1d00ffb4f75ab6dd9a.

Comment 4 Remy Suen

2010-08-22 07:34:12 EDT

*** Bug 323275 has been marked as a duplicate of this bug. ***