Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323197

Summary:

NPE in pdebuild if a dropins/somefile.link has a path that doesn't exist

Product:

[Eclipse Project] PDE

Reporter:

John Cortell <john.cortell>

Component:

Build

Assignee:

pde-build-inbox <pde-build-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aniefer, darin.eclipse

Version:

3.6

Target Milestone:

3.6.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
NPE stack crawl	none
patch	none

Description John Cortell

2010-08-19 19:17:57 EDT

See attached exception callstack.

PluginPathFinder.getDropins() doesn't consider that getSitePath() might return null, and blindly creates a java.io.File object with the result.

Note that getSites() does protect itself from the same thing.

Comment 1 John Cortell

2010-08-19 19:18:15 EDT

Created attachment 177056 [details]
NPE stack crawl

Comment 2 Andrew Niefer

2010-08-20 12:17:39 EDT

Created attachment 177109 [details]
patch

Comment 3 Darin Wright

2010-08-20 12:24:29 EDT

+1 for 3.6.1

Comment 4 Andrew Niefer

2010-08-20 12:30:44 EDT

Done in HEAD and 361.  Too bad all the bugs aren't this easy :)