Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323173

Summary: ToggleBreakpointAdapter should never create a breakpoint on the workspace root
Product: [WebTools] JSDT Reporter: Michael Rennie <Michael_Rennie>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact: Simon Kaegi <simon_kaegi>
Severity: normal    
Priority: P3 CC: thatnitind
Version: 3.2   
Target Milestone: 3.3 M2   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
fix none

Description Michael Rennie CLA 2010-08-19 12:23:11 EDT
Created attachment 177022 [details]
fix

code from HEAD

we have some bogus logic in our ToggleBreakpointAdapter that will return the workspace root as a resource for a line or function breakpoint if the JavaScriptModel fails to return the backing resource. This is bogus because the breakpoint cannot be removed easily, and it won't appear in the editor you tried to put it in.

The patch removes this logic and correctly reports to the status line why the breakpoint could not be created.
Comment 1 Michael Rennie CLA 2010-08-19 12:24:05 EDT
applied to HEAD