Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323072

Summary: Improve History View
Product: [Technology] EGit Reporter: Chris Aniszczyk <caniszczyk>
Component: UIAssignee: Mathias Kinzler <mathias.kinzler>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: mathias.kinzler, matthias.sohn, remy.suen
Version: 0.9.0   
Target Milestone: 0.12-M1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
History View none

Description Chris Aniszczyk CLA 2010-08-18 14:09:24 EDT
At the moment, the change status of a commit is text. We can probably do better than this with a label provider that shows images represent the status. We could probably get rid of one column also and just use the 'Path' column.

On top of that, we can consider shortening the path to just show the last segment and a tooltip with the full segments.

Thoughts? I just see a lot of real estate wasted at the moment.
Comment 1 Chris Aniszczyk CLA 2010-08-18 14:10:08 EDT
Created attachment 176924 [details]
History View
Comment 2 Remy Suen CLA 2010-08-19 21:02:53 EDT
(In reply to comment #0)
> On top of that, we can consider shortening the path to just show the last
> segment and a tooltip with the full segments.

Not entirely sure I am down with this idea personally.
Comment 3 Chris Aniszczyk CLA 2010-08-20 10:42:41 EDT
What would you suggest instead?

It's terrible now.

The whole path is kinda useful for me...
Comment 4 Remy Suen CLA 2010-08-20 11:05:43 EDT
(In reply to comment #3)
> What would you suggest instead?

I'm not sure but I don't like the tooltip idea.

You could make it configurable so it's either just the file's name or the full path. :P

> The whole path is kinda useful for me...

Did you mean to say "useless"? :O
Comment 5 Mathias Kinzler CLA 2010-08-25 03:23:38 EDT
Another suggestion for the resource list: we should have context menus for "Open revision in Editor" vs. "Diff revision against predecessor". Currently, you always need to toggle the "Compare mode" button and use double-click.
Comment 6 Mathias Kinzler CLA 2010-10-29 11:45:54 EDT
Code review at http://egit.eclipse.org/r/#change,1825
Comment 7 Matthias Sohn CLA 2010-11-04 17:53:25 EDT
merged Mathias' change as e2436108447d6dac104c52a2688e7acd5ebde19f, are you happy and we can close this ?
Comment 8 Mathias Kinzler CLA 2011-03-30 07:08:19 EDT
Chris, we have had quite some changes here in the meantime. Is there anything left from your point of view? If yes, could you clarify? If no, could you close?
Comment 9 Chris Aniszczyk CLA 2011-03-30 10:28:55 EDT
This is pretty generic so I will close this as fixed for 0.12

I'll open bugs for anything specific that is missing.

Thanks guys.