Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 323029

Summary:	CVS diff should use (or at least allow) -p option
Product:	[Eclipse Project] Platform	Reporter:	Jennifer Hodgdon <yahgrp>
Component:	CVS	Assignee:	platform-cvs-inbox <platform-cvs-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	tomasz.zarna
Version:	3.4.1
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Jennifer Hodgdon

2010-08-18 10:14:36 EDT

Build Identifier: M20080911-1700

I am a contributor to the Drupal open source project, and use Eclipse as my IDE. The Drupal folks prefer that I make patches with

cvs diff -up

(to show the function names the patch chunks are inside)

Eclipse supports unified diffs, but it doesn't support -p (at least as far as I know -- I've tried Google, reading the doc, looking at options, etc. -- if it's possible to do, then this is a documentation bug. :) ).

Reproducible: Always

Steps to Reproduce:
1. Use the Team menu to create a patch on a CVS-shared project.
2. The -p option cannot be specified.
3. The patch file does not show function names.

Comment 1 Tomasz Zarna

2010-08-18 10:38:15 EDT

afaik -p is for C functions only, so to get a bigger audience I would suggest adding support for -F which works with regexes (e.g. ‘^[[:alpha:]$_]’ for C). What do you think?

Comment 2 Jennifer Hodgdon

2010-08-18 10:50:27 EDT

-p actually works OK (not perfect but OK) for PHP as well as C, and it is fairly standard in PHP open-source projects to use diff -up. Probably other languages using C-like syntax (Java, etc.) would also work OK with -p, but I don't have direct experience with them to verify.

How about just adding the generic ability to put additional command-line options on the cvs diff command, so that I could use -up, and others could use -f?

Comment 3 Tomasz Zarna

2010-08-18 11:19:46 EDT

Well, we cannot be too flexible here because we must be able to consume our own patches (generated with Eclipse) i.e. we must be able to parse such patches and apply them.

Comment 4 Jennifer Hodgdon

2010-08-18 11:33:50 EDT

That makes sense.

-p certainly doesn't pollute patches for Eclipse...

Comment 5 Eclipse Webmaster

2019-09-06 16:14:59 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.