Bugzilla – Full Text Bug Listing
| Summary: | ActionBarContributor cleanup | ||
|---|---|---|---|
| Product: | [Modeling] Graphiti | Reporter: | Michael Wenz <michael.wenz> |
| Component: | Core | Assignee: | Project Inbox <graphiti-inbox> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | juergen.pasch |
| Version: | 0.7.0 | Flags: | michael.wenz:
indigo+
|
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | Indigo M7 theme_round_offs | ||
|
Description
Michael Wenz
Thinks to check: 1. Put only the most commonly used commands on the view toolbar. Any command on a toolbar must also appear in a menu, either the window menu, context menu or the view menu. http://wiki.eclipse.org/User_Interface_Guidelines#Toolbars_2 2. If a view or editor has support for Cut, Copy, Paste, or any of the global commands, these commands must be executable from the same commands in the window menu bar and toolbar. http://wiki.eclipse.org/User_Interface_Guidelines#Menus and http://wiki.eclipse.org/User_Interface_Guidelines#Integration_with_the_Window_Menu_Bar_and_Toolbar The above text and links are related to views and not to editors in the UI guidelines. Therefore, these issues are clarified here again. A VIEW consists of a title area, a (view specific) toolbar, a (view specific) pulldown menu, and an embedded control, which comprises a context menu. The context menu is used for selection oriented commands ( 7.13), while the pulldown menu shall offer presentation commands (7.10). The (view specific) toolbar is used to expose the most commonly used commands in a view (7.12). Any command on this view toolbar must also appear either in the context menu or the pull down menu. Examples for 7.12 are hard to find, because integration with the Window Menu Bar and Toolbar is similiar: if a view has support for Cut, Copy, Paste, or any of the global commands, these commands must be executable from the same commands in the window menu bar and toolbar (7.19). The guidelines for EDITORS are simpler, they do not have specific toolbars and pull down menus and no presentation commands. 1. All of the commands, except for the obvious commands, available in the editor should be added to the window menu bar (6.7). 2. If an editor has support for Cut, Copy, Paste, or any of the global commands, these commands must be executable from the same commands in the window menu bar and toolbar (6.9). 3. An editor may contribute commands directly to the window toolbar. The toolbar is used to expose the most commonly used commands in an editor. Any command which appears in the toolbar must also appear in the menu, but there is no need to duplicate every command in the menu within the toolbar (6.10). 4. Fill the context menu with selection oriented commands (6.11). All commands for the view (or editor) should be made available on the main menubar, and only frequently used commands are on the context menu. CHECK if Graphiti follows the rules 1 - 4. When checking 1, take notice of guideline 6.8. For 1-4 consider the selection state of the command (6.13). For 4 take account of 6.12 - 6.15 Wrong behaviour of selection states in actions are corrected. The main menu bar is extended with: File-> Export Diagram..; Edit-> Remove, Update, Align-> <all alignment commands>. Short cuts needed adjustments and accelerators for Export Diagram, Remove and Update are implemented. Part of 0.8.0 Part of Graphiti Indigo 0.8.0 |