| Summary: | add agent capability to request dialog on tcf server | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Kirk Beitz <kirk.beitz> | ||||||
| Component: | cdt-debug-edc | Assignee: | Ken Ryall <ken.ryall> | ||||||
| Status: | RESOLVED WONTFIX | QA Contact: | Ken Ryall <ken.ryall> | ||||||
| Severity: | minor | ||||||||
| Priority: | P3 | ||||||||
| Version: | 7.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
marking "minor" because there's not yet anything requiring this to be present; it simply allows for some visual testing. Created attachment 179184 [details]
updated patch for LoggingService.cpp+.h to make use of new ILogging dialog()
patch replaced with one directly derived from source location move to src/common_agent from src/win_agent.
(this is part of a batch change) The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix. The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/ |
Created attachment 176866 [details] changes to LoggingService.cpp/.h to make use of new ILogging dialog() for events in the debug agent that should alert the user of the debugger with a dialog, ILogging service has been modified to accept a "dialog" event, which will be presented with an eclipse CDTDebugPlugin ErrorDialog dialog to the user, replete with choice of severity, a summary field, and details that can be expanded as usual. the attached patch includes the changes necessary in the LoggingService cpp and h files in the edc windows debug agent to make use of this new feature, if desired. the recommendation is that the files that currently exist in src/win_agent be moved to src/common_agent, as there is nothing windows specific about this the "write", "writeln" or the new "dialog" service available in ILogging or in this implementation. (this patch might not apply completely cleanly without its pre-cursor patch in 322609 which cleans up numerous warnings in the edc windows agent. hitting the diff in the attachment section should present the set of diffs that would be made in the end.)