Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322975

Summary:	FeatureData writes attributes without encoding
Product:	[Eclipse Project] PDE	Reporter:	Thomas Hallgren <thomas>
Component:	UI	Assignee:	Martin Karpisek <martin.karpisek>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, Lars.Vogel, martin.karpisek, Vikas.Chandra
Version:	3.6	Keywords:	helpwanted
Target Milestone:	4.7 M4
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/83297 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=22c05f142881289b22e11436831f244d2db36f29
Whiteboard:

Description Thomas Hallgren

2010-08-18 02:04:38 EDT

The recent introduction of filters in feature's includes/requires (see bug 293715) leads to problems when a feature is serialized. The class org.eclipse.pde.internal.core.feature.FeatureData simply writes the filter attribute as a string without encoding the '&' character into the XML entity &amp;.

The writeAttribute method of that class needs some escape mechanism when writing the actual value (FeatureData.java line 80).

Comment 1 Curtis Windatt

2010-08-18 09:28:44 EDT

Needs investigation

Comment 2 Thomas Hallgren

2010-10-15 02:11:34 EDT

Any progress with the investigation?

We create features that import platform specific fragments. The feature itself isn't platform specific and contains fragments for all platforms. Without the filters, we get lots of build time warnings about 'Plug-in reference x.y.z cannot be resolved' for all references that doesn't match the current platform. That's because the plug-in itself has a filter.

Comment 3 Curtis Windatt

2010-10-18 15:05:31 EDT

This is not a priority item and has not been looked at.  Assistance from the community would be appreciated.

Comment 4 Eclipse Genie

2016-10-15 09:28:56 EDT

New Gerrit change created: https://git.eclipse.org/r/83297

Comment 5 Eclipse Genie

2016-11-28 15:02:37 EST

Gerrit change https://git.eclipse.org/r/83297 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=22c05f142881289b22e11436831f244d2db36f29

Comment 6 Lars Vogel

2016-11-28 15:02:56 EST

Thanks Martin.

Comment 7 Vikas Chandra

2016-12-05 04:23:05 EST

Martin, can you please verify this fix in latest 4.7?

Comment 8 Martin Karpisek

2016-12-06 15:28:02 EST

verified by doing serialization of feature data

Version: Oxygen (4.7)
Build id: I20161205-2000