Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322954

Summary: [model] Improper reconciliation of soap:body parts when used in a MIME binding context
Product: [WebTools] WTP Webservices Reporter: Valentin Baciu <valentinbaciu>
Component: wst.wsdlAssignee: Valentin Baciu <valentinbaciu>
Status: CLOSED FIXED QA Contact: Keith Chong <keith.chong.ca>
Severity: normal    
Priority: P3 CC: ccc
Version: 3.0.5Flags: keith.chong.ca: review+
Target Milestone: 3.0.5 P   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 322955, 322956    
Attachments:
Description Flags
JUnit
none
Patch none

Description Valentin Baciu CLA 2010-08-17 16:54:48 EDT
The WSDL EMF model's DOM to model reconciliation code for a SOAP body object assumes that the SOAP body extensibility element is a direct child of a binding's input/output/fault. This is not always the case, in particular when a SOAP body is used inside a MIME binding.

      <wsdl:input name="myOpRequest">
        <mime:multipartRelated>
          <mime:part>
            <soap:body parts="in1" use="literal"/>
          </mime:part>

Because of this assumption, the value of the parts attribute is not saved in the model and thus will be lost when forcing the model to reconcile the DOM using updateElement(true).

JUnit and fix to follow shortly.
Comment 1 Valentin Baciu CLA 2010-08-17 19:03:12 EDT
Created attachment 176851 [details]
JUnit

Apply to org.eclipse.wst.wsdl.tests. Run org.eclipse.wst.wsdl.tests.AllTestCases as a JUnit plug-in test. The new test case will fail.
Comment 2 Valentin Baciu CLA 2010-08-17 19:04:05 EDT
Created attachment 176852 [details]
Patch

Apply to org.eclipse.wst.wsdl, R3_0_5_patches branch.
Rerun the JUnits, all should be green.
Comment 3 Valentin Baciu CLA 2010-08-18 10:35:11 EDT
Keith, please review and consider approving this fix for 3.0.5 patches.
Comment 4 Keith Chong CLA 2010-08-19 11:16:54 EDT
Valentin, patch and junit tests look good.
Comment 5 Carl Anderson CLA 2010-08-20 08:07:02 EDT
Committed to R3_0_5_patches
Comment 6 Valentin Baciu CLA 2010-08-25 11:49:38 EDT
Verified. Closing.