Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322938

Summary: Internal component path info bleeding through EAR J2EE Module Dependencies properties page
Product: [WebTools] WTP Java EE Tools Reporter: Jason Sholl <jsholl>
Component: jst.j2eeAssignee: Jason Sholl <jsholl>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc
Version: 3.0.5Flags: cbridgha: review+
Target Milestone: 3.0.5 P   
Hardware: PC   
OS: Windows Server 2003   
Whiteboard:
Attachments:
Description Flags
While adding external jar
none
Afterwards
none
Patch for 305P none

Description Jason Sholl CLA 2010-08-17 13:38:43 EDT
The following problem has been fixed in the 3.2 codebase with the new Module Assemblies properties pages.

From the EAR's J2EE Module Dependencies properties page, click 'Add External Jars...' and then select a jar on disk, e.g c:\temp\foo.jar.  The table will now show the entry as 'lib/C:/temp/foo.jar'.  If you click OK and then reopen the page it will be shown as 'foo.jar'.  See screenshots.  The 'lib/C:/temp' portion should not be shown to the user.

While this is strictly a UI issue, it is confusing because of the 'In Lib Dir' checkbox column visible in 5.0 EARs has nothing to do with the 'lib/' portion of the first column.
Comment 1 Jason Sholl CLA 2010-08-17 13:42:15 EDT
Created attachment 176817 [details]
While adding external jar
Comment 2 Jason Sholl CLA 2010-08-17 13:42:39 EDT
Created attachment 176818 [details]
Afterwards
Comment 3 Jason Sholl CLA 2010-08-17 13:45:34 EDT
Created attachment 176819 [details]
Patch for 305P

This fixes the label provider to approximate the resulting jar/module name after the add is complete.  This will be accurate most of the time, but may be slightly different in the case of variables, but it will be better than the current behavior where the 'var/' bleeds through.  This will always hide the internal path information the user should not see.
Comment 4 Chuck Bridgham CLA 2010-08-17 13:52:52 EDT
approved
Comment 5 Carl Anderson CLA 2010-08-20 08:08:19 EDT
Committed to R3_0_5_patches