Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322887

Summary: [Mac] [Commands] Command from 'org.eclipse.ui.cocoa' fragment references category defined in 'org.eclipse.ui.cheatsheets'
Product: [Eclipse Project] Platform Reporter: Prakash Rangaraj <prakash>
Component: UIAssignee: Prakash Rangaraj <prakash>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: apeeters, christian.kesselheim, pwebster, remy.suen
Version: 3.6Flags: pwebster: review+
Target Milestone: 3.6.1   
Hardware: Macintosh   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on: 311963    
Bug Blocks:    

Description Prakash Rangaraj CLA 2010-08-17 07:11:30 EDT
+++ This bug was initially created as a clone of Bug #311963 +++

Build Identifier: I20100429-1549

It seems that there's a category reference coming from the cocoa fragment for org.eclipse.ui which pointing to a category defined in org.eclipse.ui.cheatsheets:

http://dev.eclipse.org/viewsvn/index.cgi/org.eclipse.ui.cocoa/fragment.xml?view=markup

As a result, simply creating a new RCP application by means of e.g. the "Hello RCP" template and then hitting start without further ado results in a unnecessary warning message being dumped to the user's console:

!ENTRY org.eclipse.ui 2 0 2010-05-06 21:23:30.561
!MESSAGE Warnings while parsing the commands from the 'org.eclipse.ui.commands' and 'org.eclipse.ui.actionDefinitions' extension points.
!SUBENTRY 1 org.eclipse.ui 2 0 2010-05-06 21:23:30.562
!MESSAGE Commands should really have a category: plug-in='org.eclipse.ui', id='org.eclipse.ui.cocoa.closeDialog', categoryId='org.eclipse.ui.category.dialogs'

One would think that the org.eclipse.ui.category.dialogs category should either belong to org.eclipse.ui instead of org.eclipse.ui.cheatsheets or the cocoa shouldn't reference this category after all.

Reproducible: Always

Steps to Reproduce:
1. Create an empty RCP application on MacOSX Cocoa
2. Start with minimal plug-ins (that is, no org.eclipse.ui.cheatsheets)
Comment 1 Prakash Rangaraj CLA 2010-08-17 07:16:54 EDT
Paul,
   Can you review the patch v01 on the original bug (https://bugs.eclipse.org/bugs/attachment.cgi?id=167660) and approve it for 3.6.1?
Comment 2 Paul Webster CLA 2010-08-23 14:05:08 EDT
Prakash, were you able to branch and submit this?  Wednesday 08:00 EDT will be our "final" RC2 build.

PW
Comment 3 Prakash Rangaraj CLA 2010-08-24 13:17:56 EDT
Patch v01 released to R3_6_maintenance branch
Comment 4 Prakash Rangaraj CLA 2010-08-26 03:15:54 EDT
Verified in M20100825-0800