Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322761

Summary: [Dawn] Plugins have 2 activators
Product: [Modeling] EMF Reporter: Eike Stepper <stepper>
Component: cdo.dawnAssignee: Martin Fluegge <martin.fluegge>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 Flags: stepper: review+
Version: 4.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch v1 none

Description Eike Stepper CLA 2010-08-16 05:17:14 EDT
Some Dawn manifests point to top-level classes called Activator. This prevents the OM framework from properly working. Is that intended?
Comment 1 Martin Fluegge CLA 2010-08-17 12:57:27 EDT
Created attachment 176813 [details]
Patch v1

I changed the Activators to internal instances of an OM class inside the plug-ins. Except for one plug-in where I completely removed it. Please check whether this is now more coherent to the rest of the project.
Comment 2 Eike Stepper CLA 2010-08-17 12:59:26 EDT
Martin, you don't need reviews for changes in your own projects. For important things you may ask for them, though ;-)
Comment 3 Martin Fluegge CLA 2010-08-17 13:06:25 EDT
This time I really wanted you to have a look at it ;) 

Just to make sure that CDO and Dawn are in accordance with each other and I did not miss anything.

But if you have such trust in me, I'll go ahead and commit the patch. ;)
Comment 4 Martin Fluegge CLA 2010-08-17 13:30:20 EDT
Solved and committed to HEAD.
Comment 5 Eike Stepper CLA 2011-06-23 03:41:53 EDT
Available in R20110608-1407