Bugzilla – Full Text Bug Listing
| Summary: | SourceLookupTab, CommonTab and EnvironmentTab reference Java in context help | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Michael Rennie <Michael_Rennie> | ||||
| Component: | Debug | Assignee: | Michael Rennie <Michael_Rennie> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | darin.eclipse, pawel.1.piech | ||||
| Version: | 3.7 | Flags: | pawel.1.piech:
review+
|
||||
| Target Milestone: | 3.7 M2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Applied. Added additional comments to state that not all tabs honor the context help setting, and doc to the Common, Env, and Source Lookup tabs to state that they do honor the setting. We should probably offer generic help for the Common and Evnvironment tabs that does not refer to Java debugging (but there is another bug for separating the platform and JDT debug doc). Fixed. Reviewed. |
Created attachment 176570 [details] proposed fix code from HEAD All of the mentioned tabs reference Java-specific help topics in their context help, which is not appropriate in non-Java usages (obviously). We should provide a way for consumers to hook in their own help context ids to the tabs. One way would be to add setHelpContextid(String) and a getHelpContextId() this way we would not break the noextend API contract on the three tabs. The attached patch provides the mentioned methods in AbstractLaunchConfigurationTab, and provides a default set* call within each of the three tabs.