Bugzilla – Full Text Bug Listing
| Summary: | Cleanup warnings for CDT EDC org.eclipse.cdt.debug.edc.windows.agent | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Kirk Beitz <kirk.beitz> | ||||||
| Component: | cdt-debug-edc | Assignee: | Ken Ryall <ken.ryall> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Ken Ryall <ken.ryall> | ||||||
| Severity: | trivial | ||||||||
| Priority: | P3 | CC: | cdtdoug, john.cortell | ||||||
| Version: | 7.0 | ||||||||
| Target Milestone: | 8.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 323997 | ||||||||
| Attachments: |
|
||||||||
Created attachment 176514 [details] patch to cleanup warnings in org.eclipse.cdt.debug.edc.widows.agent building the edc windows agent results in a number of warnings at the moment. they can be cleaned up with the attached patch. - almost all warnings that show up in "Problems" currently are of the form of "deprecated auto conversion from string to char*", where the arg or variable causing such a warning is easily declared "const char*" instead. - one change that's a consequence of the preceding change is that to Logger::Log(). the function has been changed to take const std::string& to disambiguate the varargs version from the one without varargs. at the most nit-picky level, this should be a performance gain rather than a hit due to the fact that the only callers of this function at this point in time were already storing the value in a std::string and performing .c_str() to pass the arg. - there are several instances of assignment from function calls to variables that are never used. the patch comments out these variables, but leaves the comments in a position of pseudo-assignment for a certain readability regarding the performance of the call at that point in the function.