Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322599

Summary:

Refactoring: Standardize Input Output Format

Product:

[Tools] PTP

Reporter:

Mariano Mendez <marianomendez>

Component:

Photran.Refactoring Engine

Assignee:

Mariano Mendez <marianomendez>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

enhancement

Priority:

CC:

com-eclipse-dot-org

Version:

unspecified

Target Milestone:

7.0

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
the patch file	com-eclipse-dot-org: iplog+

Description Mariano Mendez

2010-08-12 18:40:54 EDT

Build Identifier:  I20100608-0911

This refactoring replaces all format statements with a string that contains the format statement  string. It works with print , read and write statemens.



Reproducible: Always

Comment 1 Mariano Mendez

2010-08-12 18:42:08 EDT

Created attachment 176511 [details]
the patch file

Comment 2 Jeffrey Overbey

2010-09-21 12:06:13 EDT

Thanks, Mariano.  Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 3 Mariano Mendez

2010-10-04 20:02:10 EDT

 
 1. I wrote 100% of the code without incorporating content from elsewhere or
 relying on the intellectual property of others,
 
 2. I have the right to contribute the code to Eclipse, and
 
 3. I have included the EPL license header in all source files

Mariano

Comment 4 Jeffrey Overbey

2011-03-16 18:05:59 EDT

Hi Mariano,

Sorry for not getting to this sooner.

Some of your test code (parts of test5.f90, for example) seems to have come from another system.  See, for example, http://ncas-cms.nerc.ac.uk/code_browsers/UM4.5/UMbrowser/html_code/UM/ROWCALC.F.html

That code appears to be under a license that precludes redistribution...

C If no contract has been raised with this copy of the code, the use,
C duplication or disclosure of it is strictly prohibited.  Permission
C to do so must first be obtained in writing from the Head of Numerical
C Modelling at the above address.

...which means that this definitely won't pass IP review (and "I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others" and "I have the right to contribute the code to Eclipse" are not true, which will raise some red flags with the IP team).

I am going to close this bug as WONTFIX; when you get time, please resubmit the patch under a new bug, and please include only test code that you hand-wrote yourself.  (Obviously, it's good to test it on third-party code; we just can't include any parts of that code in the CVS repository unless it is under an EPL-compatible license and goes through an extensive review process by the IP team.)

Sorry about the inconvenience, but the Eclipse Foundation is very strict about copyright/intellectual property concerns.  And if we violate them, they blame me, since I'm the one putting the code in CVS.  :-)

Jeff

Comment 5 Mariano Mendez

2011-03-20 10:51:45 EDT

(In reply to comment #4)
 I will take test5 aout from the code ! :) 

Mariano