Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322514

Summary: JPA editor should be able to create java entity from mapped superclass
Product: [WebTools] Dali JPA Tools Reporter: Stefan Dimov <stefan.dimov>
Component: Diagram EditorAssignee: Petya Sabeva <petya.sabeva>
Status: RESOLVED FIXED QA Contact: Stefan Dimov <stefan.dimov>
Severity: normal    
Priority: P3    
Version: 0.5   
Target Milestone: 0.5 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch
none
Patch is updated...
none
Mark the first patch as invalid
none
Mapped superclass icon
none
patch
none
patch stefan.dimov: iplog+

Description Stefan Dimov CLA 2010-08-12 07:59:25 EDT 
Sometimes the user would want to create java entity from new or already existing mapped superclass. I believe it could elegantly implemented like this:

1. When the user drags and drops a mapped superclass from the project explorer into the diagram the mapped superclass should not appear in the diagram. Instead, a new java entity, which inherits this superclass, should be created and visualized in the diagram

2. In the palette on the left, in the section 'Entities' should appear a new item named: 'Inherited Entity' or something like that. When the user chooses this item a new mapped superclass and a new entity should be created and the entity should be visualized into the diagram.
Comment 1 Petya Sabeva CLA 2010-08-26 04:03:42 EDT 
Created attachment 177502 [details]
patch

I am not sure about the feature name in the pallete. It should be discussed.
Comment 2 Stefan Dimov CLA 2010-08-31 10:33:55 EDT 
The patch is not cpmaptible with the current HEAD version of the JPA editor. Perhaps, something is missing in the patch ...
Comment 3 Stefan Dimov CLA 2010-08-31 10:34:56 EDT 
(In reply to comment #2)
> The patch is not cpmaptible with the current HEAD version of the JPA editor.
> Perhaps, something is missing in the patch ...

Sorry for the misspelling:
cpmaptible = compatible
Comment 4 Petya Sabeva CLA 2010-09-01 02:20:53 EDT 
Created attachment 177915 [details]
Patch is updated...
Comment 5 Petya Sabeva CLA 2010-09-01 02:21:39 EDT 
Created attachment 177916 [details]
Mark the first patch as invalid
Comment 6 Stefan Dimov CLA 2010-09-01 06:32:21 EDT 
I have four notes:

1. If the (already existing) mapped superclass is in another package the new entity (created with drag-and-drop) has error because it's being created without necessary import clause.

2. If the mapped superclass has already an id it seems proper default to create the new entity without id. It will be inheritted from the superclass.

3. The new palette item should have a different icon than "Java Entity". Perhaps we should use the icon for the mapped superclass (see the attachment)

4. I'd prefer shorter text for the new palette item. Perhaps "Inheritted Entity" would be fine. (This one is my fault, because we should've discuss it earlier)
Comment 7 Stefan Dimov CLA 2010-09-01 06:34:20 EDT 
Created attachment 177928 [details]
Mapped superclass icon
Comment 8 Petya Sabeva CLA 2010-09-01 09:12:26 EDT 
Created attachment 177947 [details]
patch

This patch now implements the four notes mentioned in the previous comment.
Comment 9 Petya Sabeva CLA 2010-09-01 09:58:50 EDT 
Created attachment 177953 [details]
patch

This patch is modified to be compatible with the version in the head.
Comment 10 Stefan Dimov CLA 2010-09-01 10:42:40 EDT 
Patch committed