Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322454

Summary:

Synchronize view not respecting .gitignore settings

Product:

[Technology] EGit

Reporter:

Chris Aniszczyk <caniszczyk>

Component:

Assignee:

Dariusz Luksza <dariusz.luksza>

Status:

CLOSED FIXED

QA Contact:

Severity:

major

Priority:

CC:

dariusz.luksza, fenton.travers, Knut.Friedhelm, malaperle, mgorovoy, mn, nboldt, robin, stefan.lay

Version:

0.9.0

Target Milestone:

---

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Synchronizing HEAD vs. 0.8.4	none

Description Chris Aniszczyk

2010-08-11 21:31:54 EDT

When I went to synchronize my workspace, I hit some issues with the view being overloaded with files that should be in .gitignore...

Comment 1 Chris Aniszczyk

2010-08-11 21:32:43 EDT

Created attachment 176428 [details]
Synchronizing HEAD vs. 0.8.4

Comment 2 Dariusz Luksza

2010-08-12 17:17:43 EDT

This change should fix this issue:
http://egit.eclipse.org/r/1297

Comment 3 Chris Aniszczyk

2010-08-12 20:23:03 EDT

Fixed with 057173ac27c0724152f91869133dfa163d07fc6a.

Comment 4 Stefan Lay

2010-08-13 05:49:12 EDT

I do still see resources which are listed in .gitignore.

057173ac27c0724152f91869133dfa163d07fc6a does only exclude resources via Team.isIgnoredHint which has no clue about .gitignore.

You have to use a WorkingTreeIterator which has a method isEntryIgnored().

Comment 5 Chris Aniszczyk

2010-08-13 10:32:46 EDT

That's correct, only derived resources are accounted for atm.

Comment 6 Dariusz Luksza

2010-08-13 11:17:37 EDT

(In reply to comment #4)
> You have to use a WorkingTreeIterator which has a method isEntryIgnored().

I'll try to use NotIgnoredFilter on TreeWalk instead of WorkingTreeIterator.

Comment 7 Dariusz Luksza

2010-08-13 20:35:03 EDT

Change set:
http://egit.eclipse.org/r/1305

Comment 8 Chris Aniszczyk

2010-08-16 13:09:12 EDT

Fixed with d97e8442fb3d5981d5f279e4a13af9a1fdcb5ae6.

Comment 9 Michael Gorovoy

2011-03-11 19:39:41 EST

I'm seeing this issue happen on a git-svn clone of Jetty 7 repository (svn+ssh://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/jetty) created using git 1.7.1 on Ubuntu 10.10 with --stdlayout setting.

I'm using EGit 0.11.3, and trying to synchronize working copy with a local branch.

Comment 10 Dariusz Luksza

2011-03-13 20:56:37 EDT

(In reply to comment #9)
> I'm seeing this issue happen on a git-svn clone of Jetty 7 repository
> (svn+ssh://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/jetty) created using
> git 1.7.1 on Ubuntu 10.10 with --stdlayout setting.
> 
> I'm using EGit 0.11.3, and trying to synchronize working copy with a local
> branch.

Thanks for reporting this Michael. I've already push change:

http://egit.eclipse.org/r/#change,2696

that should fix this issue. This change also contains unit test that should prevent from regressions in feature.

Comment 11 Fenton Travers

2011-06-26 22:33:14 EDT

I see this too.  
Ubuntu 10.04, 
Git 1.7.3, 
EGit: 1.0.0.201106090707-r
Eclipse Indigo: Build id: 20110615-0604

Comment 12 Mykola Nikishov

2012-03-03 11:13:08 EST

[Batch change] Remove passed Target Milestones

If anyone on CC list is going to fix/implement this, feel free to assign a new, post-1.3/2.0, target milestone.

Comment 13 Robin Stocker

2013-09-27 11:37:06 EDT

I think this has been fixed some time ago.

Comment 14 Robin Stocker

2013-09-27 12:01:10 EDT

*** Bug 330019 has been marked as a duplicate of this bug. ***