Bugzilla – Full Text Bug Listing
| Summary: | Add copy implementation to CPPASTAmbiguousTemplateArgument class. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | John Liu <john_ws_liu> | ||||||
| Component: | cdt-indexer | Assignee: | Vivian Kong <vivkong> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Markus Schorn <mschorn.eclipse> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | vivkong | ||||||
| Version: | 7.0 | ||||||||
| Target Milestone: | 7.0.1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=321376 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
John Liu
Created attachment 176397 [details] a patch applied to cdt.core, cdt.core.test and cdt.core.lrparser This is a problem found during the investigation of bug 321376, https://bugs.eclipse.org/bugs/show_bug.cgi?id=321376. The patch adds a copy implementation to CPPASTAmbiguousTemplateArgument, updates a LR parser action class, CPPBuildASTParserAction.java and updates a test case, testBug311164() in AST2TemplateTests.java by adding a validation of the copied node. I run junit tests for cdt core parser and lr parser in my workspace and the updated test case passes both suite. This fix is to target 701, so I didn't update other ambiguous nodes for copy implementations, since they are not needed so far and I am reluctant to add such bunch of copy implementations in these ast nodes in 701, head stream maybe a good place to add them if we really need them. Created attachment 176409 [details]
an updated patch applied to cdt.core, cdt.core.lrparser and cdt.core.test
Applied to cdt_7_0 and HEAD. Thanks. *** cdt cvs genie on behalf of vkong *** Bug 322426 Add copy implementation to CPPASTAmbiguousTemplateArgument class for John Liu [*] CPPASTAmbiguousTemplateArgument.java 1.9.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTAmbiguousTemplateArgument.java?root=Tools_Project&r1=1.9.2.1&r2=1.9.2.2 [*] CPPBuildASTParserAction.java 1.65.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/core/dom/lrparser/action/cpp/CPPBuildASTParserAction.java?root=Tools_Project&r1=1.65.2.1&r2=1.65.2.2 [*] CPPASTAmbiguousTemplateArgument.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTAmbiguousTemplateArgument.java?root=Tools_Project&r1=1.10&r2=1.11 [*] CPPBuildASTParserAction.java 1.67 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/core/dom/lrparser/action/cpp/CPPBuildASTParserAction.java?root=Tools_Project&r1=1.66&r2=1.67 *** cdt cvs genie on behalf of vkong *** Bug 322426 Add copy implementation to CPPASTAmbiguousTemplateArgument class for John Liu [*] AST2TemplateTests.java 1.184.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java?root=Tools_Project&r1=1.184.2.1&r2=1.184.2.2 [*] AST2TemplateTests.java 1.186 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java?root=Tools_Project&r1=1.185&r2=1.186 |