Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322397

Summary: The entire module cache is destroyed if a publisher modified modules.
Product: [WebTools] WTP ServerTools Reporter: Troy Bishop <tjbishop>
Component: wst.serverAssignee: Angel Vera <arvera>
Status: CLOSED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.2.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
possible patch arvera: iplog+, arvera: review+

Description Troy Bishop CLA 2010-08-11 11:39:48 EDT
Build Identifier: WTP 3.2

If a publisher returns 'true' for PublisherDelegate#isModifyModules() then the entire publishing cache is destroyed, which means when the delta is requested it needs to be recomputed a second time.  If the application being published is large then this can turn into a rather bad publishing performance problem.  Attached is a patch which asks the PublisherDelegate to provide a list of the IModule's that it modified so that only the cache for those modules is cleared.

Reproducible: Always
Comment 1 Troy Bishop CLA 2010-08-11 11:41:04 EDT
Created attachment 176369 [details]
possible patch
Comment 2 Angel Vera CLA 2010-08-25 16:10:15 EDT
Changes committed to 32M
Comment 3 Angel Vera CLA 2010-08-25 16:12:33 EDT
changes released to 32M
Comment 4 Angel Vera CLA 2010-08-25 16:23:45 EDT
changes committed to HEAD (3.3)
Comment 5 Angel Vera CLA 2010-08-25 16:25:07 EDT
changes released to HEAD(3.3)