| Summary: | [CA] any CA for Type Casting operators | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Silver Zachara <silver.zachara> | ||||||||
| Component: | PDT | Assignee: | PHP Core <php.core-inbox> | ||||||||
| Status: | REOPENED --- | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | ganoro, silviya, wywrzal | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Silver Zachara
Created attachment 184571 [details]
patch
Created attachment 184572 [details]
unit tests
Created attachment 184573 [details]
patch
after reviewing the patch,I saw it only consider such condition if I am right: (|)$blabla my question is do we need to support: (|)ABC::getBoolean() the patch has been applied Patch looks to be applied. The fix in my opinion somewhat partial. Consider the following example (from the link): <?php $foo = 10; // $foo is an integer $bar = (boolean) $foo; // $bar is a boolean The fix will work in case you type all except the type cast and then call CA inside the (): $bar = (|) $foo; // here CA will show the types But the fix will not work in case of normal typing, e.g. you type $bar = (|) // CA will not show the types in this case before you type the variable after the () I think that it should show in any case between the (). Reopening the issue |