Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322281

Summary: Add support for features and plugin start level configuration
Product: z_Archived Reporter: Cole Markham <cole>
Component: LibraAssignee: Project Inbox <libra.warproducts-inbox>
Status: ASSIGNED --- QA Contact:
Severity: enhancement    
Priority: P3 CC: austin.riddle, holger.staudacher, kaloyan, rsternberg
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch with many changes none

Description Cole Markham CLA 2010-08-10 16:04:36 EDT 
Build Identifier: CVS Head

Our product uses features, so I extended the war product editor to add support for features. Also as mentioned on the newsgroup, the plugin start levels need to be set if using the simpleconfigurator, so I added that support as well.

Most of this functionality was copied over from the normal product editor. I tried to fix the validation where possible, but I think some parts do not work properly.

The extra functionality added in PluginSectionExtended is only used if using plugins instead of features.

There is also a fix for resolving linked resources for bug 322280.

I apologize for the patch being so intertwined with different changes, but I was just hacking it up for our needs.

Reproducible: Always
Comment 1 Cole Markham CLA 2010-08-10 16:06:07 EDT 
Created attachment 176278 [details]
patch with many changes
Comment 2 Holger Staudacher CLA 2010-08-12 04:42:55 EDT 
Hi Cole, 
it's very cool that you made the effort to create a patch to make the WAR products even better. I reviewed your patch. It looks good but I have some points to discuss.

- Your patch brakes 13 tests. The tests are included in org.eclipse.rap.warproducts.core.test. The changes should not brake the current functionality.
- The code doesn't fit our coding conventions. See http://wiki.eclipse.org/RAP/CodingConventions
- As you pointed out by yourself, the validation doesn't work anymore. But the validation is a core feature of the WAR Products because many new users don't know what's needed to export a .war file.
- Your changes include no tests. At least the new core functionality should be tested well.
- The patch includes changes for bug 322280. It would be nice if you can split these functionalities and provide a separate patch for this bug.

So, I see the need to support the things you pointed out. But in this state I can't accept the patch. It would be very nice if you can put a little bit more effort to resolve the issues I mentioned above. I will point you through problems if they coming up. We can use this bug for discussion if you want. Looking forward to a new patch ;)

Thanks for your work.

Regards Holger
Comment 3 Kaloyan Raev CLA 2011-08-18 14:22:07 EDT 
Hi fellows, it has already been an year since the last activity on this enhancement. If you don't plan to improve this patch to a state that it would be merged in the code repository, then perhaps it is better to close this bug as WONT FIX.
Comment 4 Holger Staudacher CLA 2011-08-19 04:34:40 EDT 
Cole, would you like to rework the patch?
Comment 5 Cole Markham CLA 2011-08-19 10:40:49 EDT 
At this point it's going to be a rewrite rather than rework. I took a look before the Indigo release to see if I could get it up to date, but too much had changed. The patch was made when the tooling was still in the RAP incubator before it moved to Libra. I think the PDE internals that it was using changed in the meantime as well.

I still plan on getting this done at some point since we rely on feature-based products. However, it is not a priority since our patched version works for our needs, so I don't have a timeframe for getting it done.