Bugzilla – Full Text Bug Listing
| Summary: | NPE raised when specifying positionInList in menus | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Brian de Alwis <bsd> | ||||
| Component: | UI | Assignee: | Project Inbox <e4.ui-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | ||||||
| Version: | 1.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Fix committed to HEAD Forgot to update the status. Sorry for the noise. |
Created attachment 176268 [details] patch reversing the comparisons to prevent possible NPEs BuildId: I20100806 Using a model fragment to insert a menu item that specifies a positionInList may lead to an NPE. This occurs if the traversal encounters a menu item with no elementId. Since we're doing string comparisons, and the identifier being sought is definitely not null, we can simply swap the comparison.