Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322271

Summary: [eclipse-build][debian] eclipse-pdebuild.sh does not pass -data and uses -vmargs
Product: z_Archived Reporter: Niels Thykier <niels>
Component: LinuxToolsAssignee: Linux Distros Inbox <linux.distros-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: remy.suen
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
reorder jvm args and pass -data in eclipse-pdebuild.sh
none
Refreshed the original patch for the git migration jjohnstn: iplog+

Description Niels Thykier CLA 2010-08-10 15:04:02 EDT
Build Identifier: Irrelevant

Hi

When using eclipse-pdebuild.sh it will write to ~/workspace, because eclipse-pdebuild.sh do not pass -data. Also eclipse-pdebuild.sh invokes eclipse via java -cp so using -vmargs do not make sense.

I have written a patch to fix both of these.

~Niels



Reproducible: Always
Comment 1 Niels Thykier CLA 2010-08-10 15:05:59 EDT
Created attachment 176266 [details]
reorder jvm args and pass -data in eclipse-pdebuild.sh
Comment 2 Niels Thykier CLA 2011-03-18 08:29:10 EDT
Created attachment 191501 [details]
Refreshed the original patch for the git migration

Re-submitting the patch as a git compatible patch (generated via git format-patch).  The patch can be applied with "git am $patch" (or patch -p1 < $patch + git add/commit) on top of commit bedb779[1] (current head of master branch at creation time).

Thank you in advance,
~Niels

[1] http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.eclipse-build.git/commit/?id=bedb7791752e6bd2c954582489d43ece5229b49a
Comment 3 Niels Thykier CLA 2011-08-09 10:01:57 EDT
Applied a refreshed version to HEAD[1].

~Niels

[1] http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.eclipse-build.git/commit/?id=06176095e850e1c86b2617d7325a028875a817f8
Comment 4 Jeff Johnston CLA 2011-09-21 16:17:54 EDT
Comment on attachment 191501 [details]
Refreshed the original patch for the git migration

Less than 250 lines.  Contributor is commiter.