Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322226

Summary: Make org.eclipse.e4.ui.di free from SWT
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Thomas Schindl <tom.schindl>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ob1.eclipse, remy.suen
Version: 1.0   
Target Milestone: 4.1 M2   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Bug Depends on:    
Bug Blocks: 319713    
Attachments:
Description Flags
patch which uses Realm
none
patch none

Description Thomas Schindl CLA 2010-08-10 09:19:01 EDT 
The bundle should not depend on SWT because this leads to a dependency on SWT for org.eclipse.e4.ui.workbench which is violating the core design of e4.
Comment 1 Thomas Schindl CLA 2010-08-10 09:21:39 EDT 
Created attachment 176234 [details]
patch which uses Realm

This patch makes use of the Databinding-Realm to sync events which the UI-Thread
Comment 2 Thomas Schindl CLA 2010-08-10 09:28:08 EDT 
Created attachment 176236 [details]
patch

Oleg - can you please review this change to me this looks ok
Comment 3 Oleg Besedin CLA 2010-08-10 11:36:19 EDT 
+1, one thing I'd change is that in the UIEventObjectSupplier realm is not really optional:

	@Inject @Optional
	protected Realm contextRealm;

(it was possible to get/create Display on the fly, so the Display was optional, but you can't create Realm without dependency on something else, like SWT :-).)
Comment 4 Thomas Schindl CLA 2010-08-10 13:37:10 EDT 
released with the change Oleg suggested to HEAD >= 2010-08-10