Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322186

Summary:

Add DE_DE keyboard layout

Product:

[Technology] SWTBot

Reporter:

Marko Tomljenovic <tomljenovic>

Component:

Keyboard Layouts

Assignee:

Project Inbox <swtbot-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

kai.helbig, KetanPadegaonkar, mistria, steffen.felbinger

Version:

2.0.4

Target Milestone:

2.0.5

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
DE_DE keyboard file	tomljenovic: review?
Exported junit tests with two failures	none
Events for singleQuoteTest	none
Events for alt+shift+up test	none

Description Marko Tomljenovic

2010-08-09 16:34:47 EDT

Build Identifier: SWTBot Build 595

The keyboard layout for DE_DE locale is missing.

I have created a DE_DE.keyboard according to this guide: http://wiki.eclipse.org/SWTBot/Keyboard_Layouts but the SWT/AWTKeyboardTests are failing. 
It looks like the tests must be rewritten for each keyboard layout?

PS Add a hint in the guide to run the tests as JUnit tests (not as SWTBotTest and not as JUnit plugin test)

Reproducible: Always

Comment 1 Marko Tomljenovic

2010-08-09 16:36:32 EDT

Created attachment 176191 [details]
DE_DE keyboard file

The keyboard file for the DE_DE locale.

Comment 2 Marko Tomljenovic

2010-08-09 17:16:34 EDT

(In reply to comment #1)
The SWTKeyboardTests are now running. But still two tests are failing. And I don't know how to fix them.

> Created an attachment (id=176191) [details]
> DE_DE keyboard file
> 
> The keyboard file for the DE_DE locale.

(In reply to comment #0)
> Build Identifier: SWTBot Build 595
> 
> The keyboard layout for DE_DE locale is missing.
> 
> I have created a DE_DE.keyboard according to this guide:
> http://wiki.eclipse.org/SWTBot/Keyboard_Layouts but the SWT/AWTKeyboardTests
> are failing. 
> It looks like the tests must be rewritten for each keyboard layout?
> 
> PS Add a hint in the guide to run the tests as JUnit tests (not as SWTBotTest
> and not as JUnit plugin test)
> 
> Reproducible: Always

Comment 3 Ketan Padegaonkar

2010-08-09 20:59:44 EDT

(In reply to comment #2)
> (In reply to comment #1)
> The SWTKeyboardTests are now running. But still two tests are failing. And I
> don't know how to fix them.

Could you tell me which two tests are failing and the stack trace ? You can export the test case as an XML in the junit view dropdown button somewhere and attach it to this bug.

Comment 4 Marko Tomljenovic

2010-08-10 13:03:17 EDT

Created attachment 176253 [details]
Exported junit tests with two failures

Comment 5 Marko Tomljenovic

2010-08-10 13:03:45 EDT

Created attachment 176254 [details]
Events for singleQuoteTest

Comment 6 Marko Tomljenovic

2010-08-10 13:10:32 EDT

I have added the exported test results.

The backquote test is also failing. The reason might be that on a german keyboard you have to press the backquote key twice to get two backquotes at once. If you press it just once you don't get nothing (with Shift you get the forward quotes)!

I have another question: I have added one more test for Alt+Shift+Up. During watching the test run I saw that a key-up event is coming although the 3rd key-down event (UP) has not yet been sent. The tests seem not to check the order of the events?
Should I refactor the base test class to do that or won't I get the events in the order they have been sent?

Comment 7 Marko Tomljenovic

2010-08-10 13:10:54 EDT

Created attachment 176256 [details]
Events for alt+shift+up test

Comment 8 Ketan Padegaonkar

2011-09-21 18:43:38 EDT

Fixed in rev c79429870c097a4a3d3df7f6c2d6243a87fc1515.