Bug 322168

Description Liviu Ionescu 2010-08-09 13:56:49 EDT

Build Identifier: 20100617-1415 

one of the users of my GNU ARM Plug-in (SourceForge) noticed a weird problem: when using file specific settings, the secondaryOutputs are no longer generated (I use the secondary outputs to convert from elf to hex and for other embedded specific outputs)

I studied the problem and noticed that when using file specific settings, the generated makefile is incomplete, in my case, instead of:

	# Add inputs and outputs from these tool invocations to the build variables 
	SECONDARY_FLASH += \
	t01cpp.hex \

	SECONDARY_LIST += \
	t01cpp.lst \

	SECONDARY_SIZE += \
	t01cpp.siz \

I get

	# Add inputs and outputs from these tool invocations to the build variables 
	SECONDARY_FLASH += \

	SECONDARY_LIST += \

	SECONDARY_SIZE += \

i.e. the secondaryOutputs targets are null.
 
after a debugging session on CDT, I discovered that calculateToolInputsOutputs() in GnuMakefileGenerator.java calls the embedded visit() code twice, once for the higher level tools and again for the file with specific configs.

on the first run, the getTopBuildOutputVars() map is completely filled in, including the secondary output definitions.

on the second run, the same map is completely reinitialised with empty definitions, so all settings from the first run are lost.

I'm not fully aware of the consequences (like some of the entries in the map accumulating duplicate values from each run with identical tools?), but at least in my tests not reinitialising the map for each run generated the correct secondary output definitions.

another good question is what happens with hierarchic folder settings, does the settings overwrite or accumulate?
 

the changes I made are in GnuMakefileGenerator.java, around line 3955, I entered a new line before

		addMacroAdditionPrefix(map, macroName, "", false);	//$NON-NLS-1$

and the result looks like this:

		if (!map.containsKey(macroName))
			addMacroAdditionPrefix(map, macroName, "", false);	//$NON-NLS-1$



Reproducible: Always

Steps to Reproduce:
1. create a project using a toolchain with secondary outputs
2. build the project, everything is fine, the secondary outputs are created
3. change the settings for a single file (like a preprocessor definition)
4. build the project: the secondary outputs are no longer created