Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322151

Summary:	Help menu is broken
Product:	[Eclipse Project] Platform	Reporter:	Thomas Watson <tjwatson>
Component:	SWT	Assignee:	Scott Kovatch <skovatch>
Status:	RESOLVED FIXED	QA Contact:	Silenio Quarti <Silenio_Quarti>
Severity:	normal
Priority:	P3	CC:	eclipse.felipe, njbartlett, remy.suen, Silenio_Quarti
Version:	3.7
Target Milestone:	3.7 M2
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Thomas Watson

2010-08-09 11:21:36 EDT

I20100805-1700

On my mac cocoa the help menu is broken.  Steps to reproduce:

1) Extract the I20100805-1700 Mac Cocoa build 32-bit
2) Start a fresh workspace.
3) Try to click on the help menu.

You will notice nothing happens and the rest of the menu items disappear. (File, Edit, Source etc.).

Nothing in the log to indicate an error.

Comment 1 Remy Suen

2010-08-09 11:32:42 EDT

This doesn't seem to be working for me either. SWT changed some code for bug 316238 though I'm not sure if it's related.

Comment 2 Neil Bartlett

2010-08-09 12:00:26 EDT

Works fine for me.

MacBook Pro, Mac OS 10.6.3
Java 1.6.0_15-b03-219
Eclipse I20100805-1700

Comment 3 Remy Suen

2010-08-09 12:05:52 EDT

I tried I20100804-0100 with 1.5.0.22 b03 and it was broken there too.

Comment 4 Neil Bartlett

2010-08-09 12:12:01 EDT

Correction, in my previous test Eclipse had picked up a Java 1.5 VM. The full version was 1.5.0_19-137.

However it is still working in Java 6:

java.version=1.6.0_15
java.vm.version=14.1-b02-90

Comment 5 Felipe Heidrich

2010-08-09 12:19:27 EDT

Are you using Mac 10.6 or Mac 10.5 ?

Comment 6 Thomas Watson

2010-08-09 12:38:38 EDT

I am on Mac 10.5.8.  It also fails for me with 64-bit on 1.6.0_20 VM.  It looks like others on Snow Leopard do not see the issue.

Comment 7 Thomas Watson

2010-08-09 14:11:58 EDT

Moving to SWT for now.  I don't think this issue has anything to do with UA directly.

Comment 8 Remy Suen

2010-08-09 14:14:09 EDT

I was testing on 10.5.8 also. Cannot reproduce with 3.6.0.

I've shown the problem to Silenio.

Comment 9 Silenio Quarti

2010-08-09 14:40:46 EDT

The change for bug#312195 broke this.

Comment 10 Silenio Quarti

2010-08-09 14:59:11 EDT

This line in Shell.windowDidResignKey() is causing the problem. I am going to remove this line for tomorrow's I-build since it does not seem necessary. This will not cause bug#312195 to come back.


	display.setMenuBar(null);

Comment 11 Silenio Quarti

2010-08-09 15:01:34 EDT

Fixed > 20100809.

Scott, please take a look once you are back from vacation.

Comment 12 Thomas Watson

2010-08-10 23:08:07 EDT

I don't think this made it into the I20100810-0800 build.  Did SWT get tagged in time?

Comment 13 Remy Suen

2010-08-11 04:57:17 EDT

(In reply to comment #12)
> I don't think this made it into the I20100810-0800 build.  Did SWT get tagged
> in time?

I don't think so.
http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg17220.html

Comment 14 Silenio Quarti

2010-08-11 08:52:08 EDT

Sorry, we did not tag in time for that build.

Comment 15 Scott Kovatch

2010-08-12 11:41:04 EDT

(In reply to comment #10)
> This line in Shell.windowDidResignKey() is causing the problem. I am going to
> remove this line for tomorrow's I-build since it does not seem necessary. This
> will not cause bug#312195 to come back.
> 
> 
>     display.setMenuBar(null);

Clearing the menu bar when a window resigns key made sense because there's no guarantee another window will take its place to reset the menu bar. However, I forgot that clicking on the help menu forces the window to resign key status because the user can type into the help menu. The AWT had a similar problem; I will write up a test case and verify what happens in the SWT.