| Summary: | [Forms] FormToolbar renders a separator using ControlContributions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Niels Lippke <niels.lippke> | ||||
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 1.3 | ||||||
| Target Milestone: | 1.4 M2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 176546 [details]
Simple snippet to reproduce it
When the toolbar parent background mode is set to INHERIT_DEFAULT, the separator shines through the control (Label, CLabel).
Fixed in CVS HEAD. Now, separator tool item hides the separator line if a control has been set. |
When adding a control to the form's toolbar using a ControlContribution, additionally to the control a seperator is also drawn, which is not the case in an RCP Application. To reproduce: public void createPartControl(Composite parent) { FormToolkit toolkit = new FormToolkit(parent.getDisplay()); final Form form = toolkit.createForm(parent); form.setText("Form Header"); form.getBody().setLayout(new FillLayout()); toolkit.decorateFormHeading(form); IToolBarManager mgr = form.getToolBarManager(); mgr.add(new ControlContribution("label") { @Override protected Control createControl(Composite parent) { CLabel label = new CLabel(parent, SWT.NONE); label.setText("Test"); return label; }}); mgr.update(true); }