Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322130

Summary: [inline] Inline Constant removes comments that do not belong to the extended range of the declaration node
Product: [Eclipse Project] JDT Reporter: Raksha Vasisht <raksha.vasisht>
Component: CoreAssignee: Ayushman Jain <amj87.iitr>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: amj87.iitr
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug

Description Raksha Vasisht CLA 2010-08-09 08:52:00 EDT
HEAD

See also bug 306524, bug 318471.

Test case: 

package snippet;

class A {
	
    //comment1- do not delete
	
    //comment before- delete with declaration
    static final int TEST= 1;
    //comment after- delete with declaration
    
    //comment2 - do not delete
    
    boolean b= equals(TEST);
}

The first time I apply the refactoring it works as expected, deleting only the comments that belong to the extended range of the declaration node, whereas from second time onwards it only deletes all the comments before the declaration and none of the ones after :

class A {
	
    //comment after- delete with declaration
    
    //comment2 - do not delete
    
    boolean b= equals(1);
}

Ayush, could you pls take a look and see if its related to your fix for bug 306524?
Comment 1 Ayushman Jain CLA 2010-08-09 10:17:25 EDT
(In reply to comment #0)
{..}
> Ayush, could you pls take a look and see if its related to your fix for bug
> 306524?

This is a separate, pre-existing bug I believe. I backed out the fix for 306524 but the problem was still there. So looks like something else. I'll investigate
Comment 2 Eclipse Genie CLA 2020-04-21 17:56:30 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.