Bug 322123

Description Sushant Sirsikar 2010-08-09 07:20:53 EDT

Build Identifier: M20090211-1700

When we create instance of org.eclipse.jface.viewers.TreeColumnViewerLabelProvider, we pass IBaseLabelProvider instance in it’s constructor. Please look following code snippet.

public class TreeColumnViewerLabelProvider extends
		TableColumnViewerLabelProvider {
         …
	 …
         ...

         /**
	 * Create a new instance of the receiver with the supplied labelProvider.
	 * 
	 * @param labelProvider
	 */
	public TreeColumnViewerLabelProvider(IBaseLabelProvider labelProvider) {
		super(labelProvider);
	}  
     ....
     .....
     ....... 
}

When dispose method of TreeColumnViewerLableProvider is called, then dispose method of passed IBaseLabelProvider should be called automatically. Dispose method of IBaseLabelProvider can contain cleanup code (e.g. Image  object cleanup, etc)  which might be very important for memory management.  As current implementation doesn’t call dispose method of IBaseLabelProvider, all clean up code written into that becomes redundant.


Reproducible: Always