Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322052

Summary: edc JUnit test TestLocalScopes1 relying on incorrect visibility bug in one case
Product: [Tools] CDT Reporter: Kirk Beitz <kirk.beitz>
Component: cdt-debug-edcAssignee: Ken Ryall <ken.ryall>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 CC: cdtdoug
Version: 7.0   
Target Milestone: 8.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 322051    
Bug Blocks:    
Attachments:
Description Flags
change to TestDwarfReader.java to not contain the variable "m" as one of the expected variables at location 0x10a2a (comments updated as well) cdtdoug: iplog+

Description Kirk Beitz CLA 2010-08-07 12:26:53 EDT 
Created attachment 176091 [details]
change to TestDwarfReader.java to not contain the variable "m" as one of the expected variables at location 0x10a2a (comments updated as well)

context: the test of variables acquired by getScopedVariables() at 68138 (a.k.a. 0x102a2) had been relying on the end of the broken end-of-scope testing of https://bugs.eclipse.org/bugs/show_bug.cgi?id=322051 .  

when tested properly, "m" should not appear when the cursor is sitting on the final brace of the function.

without https://bugs.eclipse.org/bugs/show_bug.cgi?id=322051, the tester probably saw the "m" when testing this, and incorrectly thought it was one of the variables to be counted when creating JUnitTest TestLocalScopes1.

careful examination of the resource files being tested, together with independent testing of the executable built and run under edc, demonstrates that the variable should not appear at the point at which the JUnit test is doing its examination.


attached fix:
- change to TestDwarfReader.java to not contain the variable m as one of the
  expected variables at location 0x10a2a (comments updated as well)
Comment 1 Ken Ryall CLA 2010-08-08 09:45:55 EDT 
Committed to HEAD.
Comment 2 CDT Genie CLA 2010-08-08 10:23:04 EDT 
*** cdt cvs genie on behalf of kryall ***
Bug 322052 -  edc JUnit test TestLocalScopes1 relying on incorrect visibility bug in one case

[*] TestDwarfReader.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.tests/src/org/eclipse/cdt/debug/edc/tests/TestDwarfReader.java?root=Tools_Project&r1=1.10&r2=1.11