Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322002

Summary:	[Commands] Undo/redo buttons for toolbar
Product:	[Eclipse Project] Platform	Reporter:	c.timmerman2+eclipse
Component:	UI	Assignee:	Kaloyan Raev <kaloyan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	aaron.lfoot, akurtakov, daniel_megert, kaloyan, Lars.Vogel, loskutov, mistria
Version:	3.5.2
Target Milestone:	4.8 M3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/62483 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=52b51949806888a25f839fe7687abb6e529d92d3 https://git.eclipse.org/r/110373 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=f228e69e9967e72b9a6fcc7a831b229f6da77718
Whiteboard:
Bug Depends on:
Bug Blocks:	206805

Description c.timmerman2+eclipse

2010-08-06 11:18:10 EDT

In Notepad++, i use those more than the "Show Whitespace Characters" button.


-- Configuration Details --
Product: Eclipse 1.2.2.20100122-1337 (org.eclipse.epp.package.java.product)
Installed Features:
 org.eclipse.platform 3.5.2.R35x_v20100210-0800-9hEiFzmFst-TiEn9hNYgDWg1XN8ulH_JvCNGB

Comment 1 Eclipse Genie

2015-12-11 09:39:23 EST

New Gerrit change created: https://git.eclipse.org/r/62482

Comment 2 Eclipse Genie

2015-12-11 09:41:48 EST

New Gerrit change created: https://git.eclipse.org/r/62483

Comment 3 Lars Vogel

2016-01-25 04:56:36 EST

Mass move to M6

Comment 4 Lars Vogel

2016-04-20 12:19:15 EDT

Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.

Comment 5 Kaloyan Raev

2017-06-05 03:59:49 EDT

There is a patch contributed for quite some time. What was wrong with it?

Comment 6 Andrey Loskutov

2017-06-05 05:27:09 EDT

(In reply to Kaloyan Raev from comment #5)
> There is a patch contributed for quite some time. What was wrong with it?

Nothing, just nobody seem to have interest on this one. I've commented on the patch, please follow there.

Comment 7 Kaloyan Raev

2017-06-05 06:23:08 EDT

Thanks! I'll remind about it again once you start the 4.8 development.
When is the earliest date you starting merging patches for 4.8? Do you wait for the official Oxygen release, or do you start earlier?

Comment 8 Dani Megert

2017-06-05 11:45:52 EDT

(In reply to Kaloyan Raev from comment #7)
> Thanks! I'll remind about it again once you start the 4.8 development.
> When is the earliest date you starting merging patches for 4.8? Do you wait
> for the official Oxygen release, or do you start earlier?

master is open for 4.8.

Comment 9 Kaloyan Raev

2017-06-06 06:19:38 EDT

Great! I updated the patch and it is ready for review.

Comment 10 Eclipse Genie

2017-09-15 06:28:28 EDT

Gerrit change https://git.eclipse.org/r/62483 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=52b51949806888a25f839fe7687abb6e529d92d3

Comment 11 Mickael Istria

2017-09-15 06:29:11 EDT

Thanks for the patch!
Please add a note about it (ideally with a screenshot) to the N&N page.

Comment 12 Alexander Kurtakov

2017-10-18 03:58:40 EDT

Kaloyan, please write N&N entry so we can resolve the bug.

Comment 13 Kaloyan Raev

2017-10-18 06:25:15 EDT

Could you give me a link to this N&N page?

Comment 14 Mickael Istria

2017-10-18 07:50:37 EDT

(In reply to Kaloyan Raev from comment #13)
> Could you give me a link to this N&N page?

https://git.eclipse.org/r/#/admin/projects/www.eclipse.org/eclipse/news

Comment 15 Eclipse Genie

2017-10-19 08:33:54 EDT

New Gerrit change created: https://git.eclipse.org/r/110373

Comment 16 Eclipse Genie

2017-10-19 08:42:28 EDT

Gerrit change https://git.eclipse.org/r/110373 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=f228e69e9967e72b9a6fcc7a831b229f6da77718

Comment 17 Lars Vogel

2017-10-19 08:42:46 EDT

Thanks, Kaloyan.

Comment 18 Aaron L

2019-03-20 17:40:28 EDT

Is there any way to override this in the plugin.xml or programmatically?  I have a custom plugin (which includes/depends on the org.eclipse.ui.id plugin)for which I would like the Undo/Redo toolbar buttons to be enabled/visible by default.

Now that Undo/Redo are "hiddenToolbarItem"s, my users must manually enable the Undo/Redo toolbar buttons via the Customize Perspective dialog.  I would like them enabled/visible by default.