Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321997

Summary:

P2 Publisher applications hide the exception which caused the ERROR result status

Product:

[Eclipse Project] Equinox

Reporter:

Katya Stoycheva <katya.stoycheva>

Component:

Assignee:

P2 Inbox <equinox.p2-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

irbull, pascal, s.yousouf

Version:

unspecified

Target Milestone:

3.7 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
If the result contains a causing exception, it is shown together with the result. There is a separate message stating with which arguments the application was run.	none

Description Katya Stoycheva

2010-08-06 10:53:14 EDT

Build Identifier: I20100406-1034

When the publishing process ends with a result status which is different than OK (i.e. a successful execution), the result is usually printed in the standard output. Usually, the result description gives no hint about the point of failure which may require the scenario to be debugged closely in order to ascertain the cause for failure. This behavior is common to all p2 publisher applications that extend from org.eclipse.equinox.p2.publisher. AbstractPublisherApplication, including the p2 product publisher and p2 features and bundles publisher.


Reproducible: Always

Steps to Reproduce:
One of the scenarios when the issue pops up is described in bug #275372

1. In Eclipse IDE 3.6, run P2 product publisher application with configured standard parameters but omitting the “flavor” parameter, e.g.:
-metadataRepository file:///D:/tools (url to an existing repository)
-artifactRepository file:///D:/tools (url to an existing repository)
-productFile d:/file.product (file path to a standard product file)
-append
2. Observe the output which contains the result without giving a link between the missing input parameter and the shown AssertionFailedException:
Status ERROR: org.eclipse.equinox.p2.artifact.repository code=0 null argument: org.eclipse.core.runtime.AssertionFailedException: null argument:

Comment 1 Katya Stoycheva

2010-08-06 10:54:08 EDT

Created attachment 176045 [details]
If the result contains a causing exception, it is shown together with the result. There is a separate message stating with which arguments the application was run.

Sample output for the scenario above:
Status ERROR: org.eclipse.equinox.p2.artifact.repository code=0 null argument:the name of provided capability org.eclipse.equinox.p2.flavor is not defined org.eclipse.core.runtime.AssertionFailedException: null argument:the name of provided capability org.eclipse.equinox.p2.flavor is not defined

Product publishing ended with the following exception:
org.eclipse.core.runtime.AssertionFailedException: null argument:the name of provided capability org.eclipse.equinox.p2.flavor is not defined
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
	at org.eclipse.equinox.internal.p2.metadata.ProvidedCapability.<init>(ProvidedCapability.java:33)
	at org.eclipse.equinox.p2.metadata.MetadataFactory.createProvidedCapability(MetadataFactory.java:424)
	at org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.createDefaultBundleConfigurationUnit(BundlesAction.java:334)
	at org.eclipse.equinox.p2.publisher.eclipse.DefaultCUsAction.generateDefaultConfigIU(DefaultCUsAction.java:45)
	at org.eclipse.equinox.p2.publisher.eclipse.DefaultCUsAction.perform(DefaultCUsAction.java:35)
	at org.eclipse.equinox.p2.publisher.eclipse.ProductAction.perform(ProductAction.java:91)
	at org.eclipse.equinox.p2.publisher.Publisher$ArtifactProcess.run(Publisher.java:207)
	at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.executeBatch(SimpleArtifactRepository.java:1032)
	at org.eclipse.equinox.p2.publisher.Publisher.publish(Publisher.java:231)
	at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.run(AbstractPublisherApplication.java:300)
	at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.run(AbstractPublisherApplication.java:270)
	at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.start(AbstractPublisherApplication.java:332)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.equinox.internal.app.AnyThreadAppLauncher.run(AnyThreadAppLauncher.java:26)
	at java.lang.Thread.run(Unknown Source)

Comment 2 Pascal Rapicault

2010-11-02 17:40:35 EDT

Fix released in HEAD