Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321981

Summary: [Refactoring, Performance, Memory] Rewrite Node Model
Product: [Modeling] TMF Reporter: Sebastian Zarnekow <sebastian.zarnekow>
Component: XtextAssignee: Project Inbox <tmf.xtext-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: sebastian.zarnekow: indigo+
Version: 1.0.0   
Target Milestone: M4   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Sebastian Zarnekow CLA 2010-08-06 08:59:47 EDT 
The NodeContentAdapter is responsible for syncing the offset information in the node model when it's changed. This is implemented by means of an EContentAdapter although the only interesting notifier type is the CompositeNode. Furthermore, nobody should alter the node model anyway besides the partial parser - which we have under full control.

To get rid of the more or less expensive addNodeContentAdapter(rootNode) we should find another way to sync the offset information, e.g. by explicitly triggering a method like NodeContentAdapter#updateCompositeNode from the parser.

See also StackOverflowError when adding the NodeContentAdapter to a deep expression tree: https://build.eclipse.org/hudson/job/Xtext-nightly-HEAD/94/consoleText
Comment 1 Sebastian Zarnekow CLA 2010-11-25 16:21:26 EST 
Pushed to master.
Comment 2 Karsten Thoms CLA 2017-09-19 17:21:51 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 17:33:14 EDT 
Closing all bugs that were set to RESOLVED before Neon.0