Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321902

Summary: Duplicate test classes should be renamed when they also contain duplicate function names
Product: z_Archived Reporter: Michael OBrien <michael.f.obrien>
Component: EclipselinkAssignee: Nobody - feel free to take it <nobody>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: eclipselink.orm-inbox, martin.grebac, petros.splinakis, tom.ware
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 321716    
Bug Blocks: 454799    
Attachments:
Description Flags
difference between duplicate JUnitCriteriaSimpleTestSuite in jpa and modelgen
none
Merging eclipselink.jpa.modelgen.test into eclipselink.jpa.test petros.splinakis: review?

Description Michael OBrien CLA 2010-08-05 12:47:19 EDT 
>There are several test suites that have the same name in different packages with nearly exactly the same code
Even though this is allowed - it occassionally causes a waste of developer time when the wrong one is selected in the navigate/search menu of eclipse.
Also, there have been several other bugs involving UOW testing where the same test case is duplicated in 3 suites - but only 2 of the functions are fixed - where the 3rd remains and gets a secondary bug attached to it.

This will occur when both classes contain the same function name at nearly the same place

>See bug# 321716 as an example
org.eclipse.persistence.testing.tests.jpa.criteria.JUnitCriteriaSimpleTestSuite.simpleModTest():1796
org.eclipse.persistence.testing.tests.jpa.criteria.metamodel.JUnitCriteriaSimpleTestSuite.simpleModTest():1766
>are out of sync

>Fix: rename or merge the test suites
Comment 1 Michael OBrien CLA 2010-08-05 12:54:13 EDT 
Created attachment 175961 [details]
difference between duplicate JUnitCriteriaSimpleTestSuite in jpa and modelgen
Comment 2 Tom Ware CLA 2010-08-24 13:34:37 EDT 
Retargetting
Comment 3 Petros Splinakis CLA 2016-05-06 07:11:39 EDT 
Created attachment 261509 [details]
Merging eclipselink.jpa.modelgen.test into eclipselink.jpa.test
Comment 5 Eclipse Webmaster CLA 2022-06-09 10:25:37 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink