Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321898

Summary:	3702a/3703 Button.java changes seems to be causing UI test failures
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	SWT	Assignee:	Scott Kovatch <skovatch>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	skovatch
Version:	3.7
Target Milestone:	3.7 M1
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Remy Suen

2010-08-05 12:06:04 EDT

Working with 3702a as a base, I am seeing some recent changes for Button.java in HEAD that seems to be causing the test failures for I200804-1800.

http://download.eclipse.org/eclipse/downloads/drops/I20100804-1800/testresults/html/org.eclipse.ui.tests_macosx.cocoa.x86_5.0.html

Comment 1 Remy Suen

2010-08-05 12:34:48 EDT

Of course, that should've been 3702a/3703. :o

Comment 2 Silenio Quarti

2010-08-05 12:46:22 EDT

Scott, please investigate this for M1.

Comment 3 Scott Kovatch

2010-08-05 14:44:15 EDT

Fixed in HEAD. I moved out the addition of a magic number in a refactoring. I think fixing the button size problems addressed the "widget is disposed" error, but I need to get a newer I-build to verify for sure.

Comment 4 Scott Kovatch

2010-08-05 15:08:00 EDT

Marking as fixed, as I can't reproduce the remaining failures. There are other failures, but I don't necessarily have the same test environment.

Comment 5 Remy Suen

2010-08-06 07:31:09 EDT

Looks good to me on I201008051700. Thank you for addressing this matter so quickly, Scott.