Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321881

Summary:

CDT editor should have selection expansion

Product:

[Tools] CDT

Reporter:

Tomasz Wesolowski <kosashi>

Component:

cdt-editor

Assignee:

Elena Laskavaia <elaskavaia.cdt>

Status:

RESOLVED FIXED

QA Contact:

Anton Leherbauer <aleherb+eclipse>

Severity:

enhancement

Priority:

CC:

aleherb+eclipse, elaskavaia.cdt, malaperle

Version:

8.0

Target Milestone:

8.0

Hardware:

OS:

Windows 7

URL:

http://wiki.eclipse.org/CDT/C_editor_enhancements/Selection_expansion

Whiteboard:

Attachments:

Description	Flags
expansion actions	none
expansion actions	elaskavaia.cdt: iplog+

Description Tomasz Wesolowski

2010-08-05 10:24:21 EDT

Edit -> Expand selection is a quick useful feature in JDT. CDT could have it too.

I'm on a good way with this, I should have it completed by tomorrow.

Comment 1 Tomasz Wesolowski

2010-08-06 07:05:58 EDT

Created attachment 176019 [details]
expansion actions

Here we go

Comment 2 Marc-André Laperle

2010-08-06 13:09:52 EDT

Hi Tomasz. This is great! I thought it was only for Expand to enclosing and restore last, those work well. I tried the next and previous element but it doesn't work as well as JDT. I think it's because it doesn't fall back to getting the parent when there is no sibling?

Also, 
"Expand Selection to..." should be "Expand Selection To"

Thanks for working on that!

Comment 3 Tomasz Wesolowski

2010-08-09 13:24:04 EDT

Created attachment 176171 [details]
expansion actions

I've never been a fan of expanding to next/previous, so I actually didn't notice that. :)
Thanks for pointing this out, I made CDT consistent with JDT here.

Comment 4 Elena Laskavaia

2010-08-12 21:02:52 EDT

Patch applied to head, thanks. Took me some time to find a menu.
I did not realize it in main Edit menu.

Comment 5 CDT Genie

2010-08-12 21:23:04 EDT

*** cdt cvs genie on behalf of elaskavaia ***
Bug 321881 - CDT editor should have selection expansion - contribution from Tomasz Wesolowski

[*] plugin.properties 1.204 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/plugin.properties?root=Tools_Project&r1=1.203&r2=1.204
[*] plugin.xml 1.385 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/plugin.xml?root=Tools_Project&r1=1.384&r2=1.385

[+] StructureSelectNextAction.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/StructureSelectNextAction.java?root=Tools_Project&revision=1.1&view=markup
[+] StructureSelectEnclosingAction.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/StructureSelectEnclosingAction.java?root=Tools_Project&revision=1.1&view=markup
[+] StructureSelectionAction.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/StructureSelectionAction.java?root=Tools_Project&revision=1.1&view=markup
[+] StructureSelectHistoryAction.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/StructureSelectHistoryAction.java?root=Tools_Project&revision=1.1&view=markup
[+] StructureSelectPreviousAction.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/StructureSelectPreviousAction.java?root=Tools_Project&revision=1.1&view=markup

[*] CEditorMessages.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/CEditorMessages.java?root=Tools_Project&r1=1.14&r2=1.15
[*] ConstructedCEditorMessages.properties 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/ConstructedCEditorMessages.properties?root=Tools_Project&r1=1.7&r2=1.8
[+] SelectionHistory.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/SelectionHistory.java?root=Tools_Project&revision=1.1&view=markup
[*] CEditor.java 1.214 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/CEditor.java?root=Tools_Project&r1=1.213&r2=1.214
[*] CEditorActionContributor.java 1.34 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/CEditorActionContributor.java?root=Tools_Project&r1=1.33&r2=1.34
[*] ICEditorActionDefinitionIds.java 1.42 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/ICEditorActionDefinitionIds.java?root=Tools_Project&r1=1.41&r2=1.42
[*] CEditorMessages.properties 1.60 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/CEditorMessages.properties?root=Tools_Project&r1=1.59&r2=1.60

Comment 6 Anton Leherbauer

2010-08-20 02:35:44 EDT

*** Bug 223052 has been marked as a duplicate of this bug. ***