Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321831

Summary:	Egit packages visibility
Product:	[Technology] EGit	Reporter:	Mathias Kinzler <mathias.kinzler>
Component:	Core	Assignee:	Chris Aniszczyk <caniszczyk>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	caniszczyk, matthias.sohn, mn, robin.rosenberg, stefan.lay
Version:	0.9.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Mathias Kinzler

2010-08-05 04:34:11 EDT

The packages in the different EGit projects are treated inconsistently: some packages with "internal" in their name are exposed to some friends; others are exposed even though they are not needed anywhere.
We should cleanup the package structure and the x-internal/x-friends/uses directives in all EGit projects.
Since we'll have to move some classes around packages, this will be a big refactoring, so it should probably be coordinated somehow in order to avoid too much merge pain for people with open changes.

Comment 1 Chris Aniszczyk

2010-08-05 15:42:59 EDT

This problem sucks.

Our packages are named poorly too.

We should be 'org.eclipse.egit.internal.core.*'

Also, I think everything in org.eclipse.egit.core and ui should be internal for now with proper x-friends relationships between core/ui.

Comment 2 Robin Rosenberg

2010-08-19 17:19:31 EDT

Does it help if I just agree?

Comment 3 Stefan Lay

2010-09-07 05:57:57 EDT

We take this up after 0.9.

Comment 4 Chris Aniszczyk

2010-11-08 08:11:32 EST

I'll look at this after 0.10, better we do this sooner than later :)

Comment 5 Mykola Nikishov

2012-02-17 08:27:24 EST

Chris, are you still going to take a look at this?