Bugzilla – Full Text Bug Listing
| Summary: | Refactoring: Move Module Entities [Contrib] [NoCQ] | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Matthew Fotzler <incongruous> | ||||||
| Component: | Photran.Refactoring Engine | Assignee: | Photran Inbox <photran-inbox> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P5 | CC: | akasza2, com-eclipse-dot-org | ||||||
| Version: | 6.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 319883 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Thanks. Matt and Ashley, can you *both* please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? Yes, I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files. Yes, I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files. Created attachment 176243 [details]
patch
This patch is closer to the spec in terms of implementation.
NOTE: We have commented out calls to reindent the modified source code, due to a bug with the reindenter.
What is the reindenter bug again? Do we have an entry for it in Bugzilla? If not, could you please file one? Then we should mark the bug dependency... Thanks. It looks like this patch includes the Add Use Statement refactoring, which is Bug 319883. We need to keep these separate. So when that bug is fixed, could you please resubmit this patch without that refactoring included in the patch? Thanks! *** Bug 319883 has been marked as a duplicate of this bug. *** We decided to include Add Use Statement as part of this refactoring. Need to try applying patch and send for IP review... from Bug 321038: "There is also a bug when attempting to reindent with the Move Module Entities refactoring that causes the majority of the file to be indented when it should not be." I didn't get this to the IP team for review in time for Indigo. I'm going to mark it P5 and revisit it after June... Unfortunately, there is no longer active development on this component. |
Created attachment 175884 [details] refactoring This refactoring implements the spec outlined in section 4.7 of the tech report for moving named entities from one module to another.