Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321789

Summary:

[Mac] Mac: Standard app-menu About and Preferences items require redundant menu items elsewhere

Product:

[Eclipse Project] Platform

Reporter:

Andy Thomas-Cramer <andy.thomascramer>

Component:

Assignee:

Platform UI Triaged <platform-ui-triaged>

Status:

VERIFIED FIXED

QA Contact:

Prakash Rangaraj <prakash>

Severity:

normal

Priority:

CC:

pwebster, thomascramera

Version:

3.6

Target Milestone:

3.7 M3

Hardware:

Macintosh

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Patch v01	none

Description Andy Thomas-Cramer

2010-08-04 15:57:26 EDT

Build Identifier: Helios platform release

Observed: 

From observation and looking at the code of org.eclipse.ui.internal.carbon.CarbonUIEnhancer, it appears that the About and Preferences items in the Mac application menu require redundant, non-standard menu items elsewhere with IDs "about" and "preferences".

For example, if I include a Help>About menu item, the application menu "About" item works correctly. If I omit Help>About, the application menu "About" does nothing, even though the "about" action is registered.

Desirable: 

The application menu "About" and "Preferences" items should work even in the absence of parallel items elsewhere in the menus.

Question:

Should the search be looking in the registry of actions rather than the menus?

Reproducible: Always

Comment 1 Prakash Rangaraj

2010-08-24 13:54:12 EDT

Scott is working on Application level menu. If that goes into 3.7, I'll try to push this as well.

Comment 2 Prakash Rangaraj

2010-10-11 14:15:07 EDT

Created attachment 180612 [details]
Patch v01

Patch v01

Comment 3 Prakash Rangaraj

2010-10-11 14:17:39 EDT

Patch v01 released to HEAD

Comment 4 Prakash Rangaraj

2010-10-12 08:03:23 EDT

(In reply to comment #3)
> Patch v01 released to HEAD

Comment 5 Prakash Rangaraj

2010-10-26 04:35:48 EDT

Verified in I20101025-1800

Comment 6 Andy Thomas-Cramer

2011-07-08 18:43:58 EDT

Prakash: Thanks for fixing this.

Others: Using the fix in an RCP app is simple -- in the ActionBarAdvisor, add the About and Preferences items to menus only if not running on a Mac.

		if ( ! isRunningOnAMac ) {
			menu.add(new Separator());
			menu.add(m_actionHelpAbout);
		}