Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321776

Summary: endless recursion in P2SiteGenerator
Product: z_Archived Reporter: Carsten Reckord <reckord>
Component: BuckminsterAssignee: buckminster.core-inbox <buckminster.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: thomas
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
avoid endless recursion in collectBundles() thomas: iplog+

Description Carsten Reckord CLA 2010-08-04 14:44:38 EDT
The P2SiteGenerator runs into an endless recursion if one attempts to edit the bundle.jars group of the site feature (to i.e. fine-tune what goes into the site)

Steps to reproduce:
1. Materialize the mailapp example
2. Add the following to org.eclipse.buckminster.tutorial.mailapp.product.feature/buckminster.cspex:

   <groups>
      <public name="bundle.jars">
         <attribute name="bundle.jars.with.test.fragments" excludePattern=".*#target.fragments"/>
      </public>
   </groups>
   <alterGroups>
      <rename newName="bundle.jars.with.test.fragments" oldName="bundle.jars"/>
   </alterGroups>

3. perform org.eclipse.buckminster.tutorial.mailapp.product.feature#site.p2

This results in a StackOverflowError stemming from an endless recursion in P2SiteGenerator.collectBundles:455. The prerequisite of the group here is not a bundle (thus not added to the map) and its CSpec is the current CSpec.
Comment 1 Carsten Reckord CLA 2010-09-16 06:44:37 EDT
Created attachment 179019 [details]
avoid endless recursion in collectBundles()

Just stumbled over this again after updating my (previously locally patched) headless installation and noticed that I forgot to add my patch here. So here it is...
Comment 2 Thomas Hallgren CLA 2011-01-26 11:46:08 EST
Patch release to helios-maintenance branch, rev 11653.

Thank you for the contribution.