Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321653

Summary: P2Utils does not correctly assign start levels to special-case platform bundles if user-defined start levels are provided
Product: [Eclipse Project] PDE Reporter: Cole Markham <cole>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: ruediger.herrmann
Version: 3.6   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch to collapse outer if none

Description Cole Markham CLA 2010-08-03 16:31:17 EDT
Created attachment 175810 [details]
Patch to collapse outer if

If P2Utils.writeBundlesTxt is called with a productFile that contains configurationInfo, then bundles such as which have special cases (equniox.simpleconfigurator, equinox.common, equinox.ds, org.eclipse.osgi, update.configurator, core.runtime) are not handled. In this case, userInfos is not null nor is it empty, so the outer if evaluates true and the else block which handles the special cases is never called.

The attached patch collapses the outer if to include a check for whether the requested bundle actually contains user-defined info. Any bundle which does not will be handled by the default logic so special cases will work properly.
Comment 1 Lars Vogel CLA 2018-12-03 09:04:25 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.