Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321563

Summary: [Unit Test Failure] org.eclipse.gmt.modisco.infra.browser.custom.tests.BrowserCustomTest.testWorkspaceCustomizationHidesRegistryCustomization
Product: [Modeling] MoDisco Reporter: Gregoire Dupe <gdupe>
Component: InfrastructureAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: fabien.giquel, hugo.bruneliere, modisco.web-inbox, nicolas.bros
Version: 0.9.0Flags: gdupe: helios+
gdupe: indigo+
Target Milestone: 0.9.0 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
details
none
Log of build 25 none

Comment 1 Gregoire Dupe CLA 2010-08-03 05:54:02 EDT 
In revision 2812, I’ve improved the error message to help to debug.
Comment 2 Gregoire Dupe CLA 2010-08-04 04:40:52 EDT 
In revision 2819, I've enabled the tracing in the AllTest's launch configuration.
Comment 3 Gregoire Dupe CLA 2010-08-04 06:13:31 EDT 
I’m not able to reproduce the bug in the modisco-nightly job but the modisco-integration job (for the version 0.8.0) has the same problem.

In revision 2820, I’ve enable tracing in the AllTest launch configuration in the 0.8.0 branch.
Comment 4 Gregoire Dupe CLA 2010-08-04 08:46:29 EDT 
In revision 2821, I've added debug messages to understand the bug. (in the branch 0.8.0)
Comment 5 Gregoire Dupe CLA 2010-08-04 10:12:22 EDT 
In revision 2831:
 - I've added synchronized key word on CatalogJob::getInstance() and CatalogJob::run(...).
 - I've added the option -consoleLog in the AllTest's launch configuration.
Comment 6 Gregoire Dupe CLA 2010-08-05 08:23:45 EDT 
Created attachment 175924 [details]
Log of build 25

In this log we can see that something wrong happened with SWT during the CatalogJob execution:
 org.eclipse.swt.SWTError: No more handles [gtk_init_check() failed]
Comment 7 Gregoire Dupe CLA 2010-08-06 12:35:36 EDT 
I’ve removed the synchronized key word. This key word may cause a dead lock the unit test run on build.eclipse.org. 

Cf. :
 - https://build.eclipse.org/hudson/job/modisco-integration/26/console
 - https://build.eclipse.org/hudson/job/modisco-integration/27/console
Comment 8 Gregoire Dupe CLA 2010-08-20 03:45:28 EDT 
In the revision 2952, I've added the keyword "synchronized" to the method CatalogJob.getInstance() in the trunk.
Comment 9 Nicolas Bros CLA 2010-09-09 08:55:02 EDT 
This test now passes successfully on Hudson.
Comment 10 Hugo Bruneliere CLA 2010-10-05 04:30:16 EDT 
Bug fixed.