Bugzilla – Full Text Bug Listing
| Summary: | [Palette] Using GTK, resizing palette does not work well and loose keyboard | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Mickael Istria <mistria> | ||||||
| Component: | GEF-Legacy GEF (MVC) | Assignee: | gef-inbox <gef-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | baptiste.mesta, h1055071, hudsonr, nyssen, peter, pwebster | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 3.7.1 (Indigo) M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux-GTK | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 342755 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Mickael Istria
I see this too. After some testing I can see that it happens on Linux only. The behavior is quite disturbing and the loss of keyboard input is even more so. A simple workaround is to run the FlyoutPaletteComposite#ResizeAction action inside FlyoutPaletteComposite#Sash#SashDragManager#mouseDown. This way the resize is less visual but it's still very usable. Now if there was a simple hack to do it in the current version... I did more testing. Palette resize still works with Eclipse 3.5.1 but it's broken on Eclipse 3.5.2 and later. Perhaps this bug is caused by the fix for GDK client side windows introduced in 3.5.2: https://bugs.eclipse.org/bugs/show_bug.cgi?id=287307. FlyoutPaletteComposite uses Control#moveAbove method to layout its components. (In reply to comment #3) > I did more testing. Palette resize still works with Eclipse 3.5.1 but it's > broken on Eclipse 3.5.2 and later. Sounds like a regression in SWT changes between 3.5.2 and 3.5.1 Created attachment 185195 [details]
Monkey patch that fixes the bug at runtime
For me waiting for a fix is not an option so I created a monkey patch that can be used in the editor to correct the problem at runtime. The code uses some private utility methods but you can easily guess what they do. Hope someone will find it useful. Eat that Ruby!
I've just noticed this bug on our RCP application on the version for Ubuntu (I don't really use Linux that much so haven't come across it until now). Basically, it makes our RCP app useless for Linux as I can't resize the palette properly. Oops. Looks like I have to re-write the app not to use a GEF flyout palette. Not much fun. Any chance of a fix? Would it be possible to nail this one for GEF 3.7? Perhaps take some of the code in Comment #6 ? (In reply to comment #8) > Would it be possible to nail this one for GEF 3.7? Perhaps take some of the > code in Comment #6 ? Well, I would prefer not to put platform-specific workarounds into GEF. We should rather try to track it down to SWT. If its a regression introduced by the fix to bug #287307 we should reopen it, otherwise file a new bug against SWT to keep track. Could you support in identifying the SWT change that caused the regression? (In reply to comment #9) > (In reply to comment #8) > > Would it be possible to nail this one for GEF 3.7? Perhaps take some of the > > code in Comment #6 ? > > Well, I would prefer not to put platform-specific workarounds into GEF. We > should rather try to track it down to SWT. If its a regression introduced by > the fix to bug #287307 we should reopen it, otherwise file a new bug against > SWT to keep track. Could you support in identifying the SWT change that caused > the regression? I wish I had the time and inclination to identify the SWT change that caused this, but I'm tired. I've had enough of chasing the never-ending regressions in Eclipse. It's time to move on. It's a losing battle. I'm done with Eclipse and the illusion of the "write once, run anywhere" Java lie. Life's too short. I'm gone. And I'm back again (my last comment was made in utter despair). This is a very serious bug for anyone who uses the GraphicalEditorWithFlyoutPalette since you lose all keyboard input after attempting to resize the palette. Here's some quick steps to reproduce: 1. On Eclipse Linux 3.6.x (try Ubuntu) create a GEF Shapes Example. 2. Attempt to Resize the Palette in the GEF Shapes Editor. 3. Now try to type on the keyboard in an Editor - no keyboard input. Sadly, I do not have the right knowledge to track it down to SWT so I'm going to try the "monkey patch" posted above. (In reply to comment #11) > And I'm back again (my last comment was made in utter despair). Good to know. That last comment made me frightened... > > This is a very serious bug for anyone who uses the > GraphicalEditorWithFlyoutPalette since you lose all keyboard input after > attempting to resize the palette. > > Here's some quick steps to reproduce: > > 1. On Eclipse Linux 3.6.x (try Ubuntu) create a GEF Shapes Example. > 2. Attempt to Resize the Palette in the GEF Shapes Editor. > 3. Now try to type on the keyboard in an Editor - no keyboard input. I can reproduce it on my Ubunto 10.04 as you describe. > > Sadly, I do not have the right knowledge to track it down to SWT so I'm going > to try the "monkey patch" posted above. I will download a 3.5.1 and 3.5.2 Eclipse and see what can be found... Created attachment 193095 [details] Revised Monkey Patch I took the Monkey Patch from Comment #6 and added the missing Reflection method. You need to add the code in the patch to any class that extends GraphicalEditorWithFlyoutPalette. I tested it on Ubuntu 10.10 and it works for me. I'll use it for my RCP app. If the bug only affected the resizing of the palette you could work around it by using the "Resize" command from the context menu on the palette but it makes keyboard input stop working which is pretty serious. Added dependency to SWT bug#432755, which was opened to keep track of the underlying SWT issue (a regression introduced by bug #290395 rather than bug #287307). (In reply to comment #14) > Added dependency to SWT bug#432755, which was opened to keep track of the > underlying SWT issue (a regression introduced by bug #290395 rather than bug > #287307). That should be Bug 342755. You guys are very clever to track this down! Just a note - this bug occurs when using the ECore Tools Diagram Editor[1] on GTK Linux. I'm surprised that nobody has noticed it. No GTK users of ECore Tools? [1] http://www.eclipse.org/modeling/emft/?project=ecoretools I was also surprised to notice that nobody in our community of users noticed this issue. Apparently, people using GTK are not used to resizing palettes... Confirmed that with Eclipse I20110425 this issue does no longer hold. Resolving as fixed in 3.7M7 though. (In reply to comment #18) > Confirmed that with Eclipse I20110425 this issue does no longer hold. Resolving > as fixed in 3.7M7 though. However, a comment I made in Bug 342755: I tested this on build eclipse-SDK-I20110425-1800-linux-gtk. In GEF Editors it is now possible to drag the palette splitter as detailed in Bug 321560. The only downside is that there are repaint issues as mentioned above. Dragging the palette splitter from left to right leaves a trail of slow repainted image sections. The "monkey patch" submitted in a comment to Bug 321560 actually works better. (In reply to comment #19) > (In reply to comment #18) > > Confirmed that with Eclipse I20110425 this issue does no longer hold. Resolving > > as fixed in 3.7M7 though. > > However, a comment I made in Bug 342755: > > I tested this on build eclipse-SDK-I20110425-1800-linux-gtk. > > In GEF Editors it is now possible to drag the palette splitter as detailed in > Bug 321560. The only downside is that there are repaint issues as mentioned > above. Dragging the palette splitter from left to right leaves a trail of slow > repainted image sections. > > The "monkey patch" submitted in a comment to Bug 321560 actually works better. Yes, I can confirm that there is indeed some "flickering" when resizing, if that is that you are referring to. However, I can reproduce it on Mac OS X as well and I think we should thus open another issue to keep track of it, as this may thus be a GEF problem, not caused by an underlying platform-specific SWT misbehavior. (In reply to comment #20) > (In reply to comment #19) > > (In reply to comment #18) > > > Confirmed that with Eclipse I20110425 this issue does no longer hold. Resolving > > > as fixed in 3.7M7 though. > > > > However, a comment I made in Bug 342755: > > > > I tested this on build eclipse-SDK-I20110425-1800-linux-gtk. > > > > In GEF Editors it is now possible to drag the palette splitter as detailed in > > Bug 321560. The only downside is that there are repaint issues as mentioned > > above. Dragging the palette splitter from left to right leaves a trail of slow > > repainted image sections. > > > > The "monkey patch" submitted in a comment to Bug 321560 actually works better. > > Yes, I can confirm that there is indeed some "flickering" when resizing, if > that is that you are referring to. However, I can reproduce it on Mac OS X as > well and I think we should thus open another issue to keep track of it, as this > may thus be a GEF problem, not caused by an underlying platform-specific SWT > misbehavior. The flickering on Mac is a separate issue. That's always been there. The Linux redraw problems are what Bogdan describes in that bug report when he says: "Note that this is not a good final solution as it will introduce considerable performance degradation for Eclipse given that there are many obscured editors and perspectives." I opened bug #343917 to keep track of the flickering problem. |