| Summary: | [navigation] Open Hyperlink > Open Implementation does not work for external files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Deepak Azad <deepakazad> | ||||
| Component: | Text | Assignee: | Raksha Vasisht <raksha.vasisht> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | minor | ||||||
| Priority: | P3 | CC: | daniel_megert | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Same is true for F4 and other commands. >Same is true for F4 and other commands.
Actually, I was only referring to the disabled action in the menu. If that's the intention then we should also not show the hyperlink in the popup.
(In reply to comment #2) > >Same is true for F4 and other commands. > Actually, I was only referring to the disabled action in the menu. If that's > the intention then we should also not show the hyperlink in the popup. For me the action is enabled in the Menu - both on Ubuntu and WinXp Of course the initial steps should have been.. (sorry for the confusion)
*Open HyperLink > Open Implementation* does nothing on files not on build path
Steps:
- Create a java file with the following snippet on the file system and open it
in eclipse
class A {
void foo() {
String s="";
System.out.println("");
System.out.append('a');
s.compareTo("");
s.equals("");
s.substring(1).equals("");
}
}
- Ctrl+click or use the *Open Hyperlink* command on 'println' or 'append' > Select 'Open Implementation' => nothing happens. 'Open Declaration' works correctly.
And of course when I said the action is enabled in menu, I meant the 'Open Hyperlink' action
>And of course when I said the action is enabled in menu, I meant the 'Open
>Hyperlink' action
And of course 'Open Implementation' is disabled as I said ;-)
Created attachment 175828 [details]
Patch
Patch committed to HEAD. Also fixes the Open Implementation in the pop up for external files.
. Looks good. I made a small change in JavaElementImplementationHyperlink (exactly the opposite direction). Verified in I20100804-1800. |
Build id : I20100802-1800 (same behavior in 3.6) Open Implementation does nothing on files not on build path Steps: - Create a java file with the following snippet on the file system and open it in eclipse class A { void foo() { String s=""; System.out.println(""); System.out.append('a'); s.compareTo(""); s.equals(""); s.substring(1).equals(""); } } - Ctrl+click or use the command on 'println' or 'append' > Select 'Open Implementation' => nothing happens. 'Open Declaration' works correctly.