Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321519

Summary: Single Root util not checking for classpath dependencies
Product: [WebTools] WTP Java EE Tools Reporter: Jason Peterson <jasonpet>
Component: jst.j2eeAssignee: Jason Peterson <jasonpet>
Status: RESOLVED WONTFIX QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc
Version: 3.0.5Flags: ccc: review+
Target Milestone: 3.0.5 P   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
ccc: iplog+
additional_patch
none
patch_to_revert ccc: iplog+

Description Jason Peterson CLA 2010-08-02 11:35:21 EDT
Created attachment 175721 [details]
patch

Projects containing classpath dependency attributes via the classpath tagging should not be considered single root.  A check for the classpath dependency attribute needs to be added to the single root utility.  This check already exists in the 3.2 stream.
Comment 1 Jason Peterson CLA 2010-08-02 11:38:10 EDT
I have also backported the fix for bug 247090 as part of my patch.  This was necessary so that classpath dependencies with a deploy path other than "../" are not added to the parent component.
Comment 2 Carl Anderson CLA 2010-08-04 12:23:36 EDT
Approved.
Comment 3 Carl Anderson CLA 2010-08-05 13:33:07 EDT
Committed to R3_0_5_patches
Comment 4 Jason Peterson CLA 2010-08-10 09:59:42 EDT
Reopening since part of this patch needs to be reverted
Comment 5 Jason Peterson CLA 2010-08-10 10:13:03 EDT
Created attachment 176240 [details]
additional_patch
Comment 6 Jason Peterson CLA 2010-08-10 11:59:07 EDT
Created attachment 176251 [details]
patch_to_revert

adding patch to revert the changes made by this bugzilla
Comment 7 Jason Peterson CLA 2010-08-10 11:59:47 EDT
added a new patch to revert the original patch.
Comment 8 Carl Anderson CLA 2010-08-11 12:00:27 EDT
Testing by the adopter has proven this to be a bad fix to make.  As such, we are undoing this from R3_0_5_patches.  The patch to remove the changes has been committed to R3_0_5_patches.