Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321484

Summary:

Buffer.startGetting does not always handle remote socket closure gracefully

Product:

[Modeling] EMF

Reporter:

Caspar D. <caspar_d>

Component:

cdo.net4j

Assignee:

Caspar D. <caspar_d>

Status:

CLOSED FIXED

QA Contact:

Eike Stepper <stepper>

Severity:

normal

Priority:

CC:

saulius.tvarijonas, vroldanbet

Version:

4.0

Flags:

stepper: review+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none
Patch v2 - ready to be committed	none

Description Caspar D.

2010-08-02 05:30:51 EDT

When the remote end of a socket is closed, on the home end of the
connection that may either cause a -1 to be returned from
SocketChannel.read(ByteBuffer), or it may cause an IOException to be
thrown from that call, with the following trace:

java.io.IOException: An existing connection was forcibly closed by the remote host
  at sun.nio.ch.SocketDispatcher.read0(Native Method)
  at sun.nio.ch.SocketDispatcher.read(Unknown Source)
  at sun.nio.ch.IOUtil.readIntoNativeBuffer(Unknown Source)
  at sun.nio.ch.IOUtil.read(Unknown Source)
  at sun.nio.ch.SocketChannelImpl.read(Unknown Source)...

The former situation (-1) we handle gracefully, while in the latter
case we dump the stacktrace. See net4j.buffer.Buffer.java, line 154.

It seems there is no clear specification of when the method will
exhibit the one or the other behavior; it seems to rather depend on
how the process owning the socket was terminated, and whether or not
that process ran on a different host or not. See for example:

  http://www.coderanch.com/t/207367/sockets/java/Detecting-client-disconnection-events

As far as I can tell, the -1 and the exception signal the same
situation, i.e. remote socket closure. So we should handle both in the
same way.

Comment 1 Caspar D.

2010-08-04 00:35:47 EDT

Created attachment 175813 [details]
Patch

Comment 2 Eike Stepper

2010-08-07 04:24:31 EDT

Created attachment 176082 [details]
Patch v2 - ready to be committed

Caspar, please clone this bug to maintenance and commit without review.

(I've added a minor change in the tests)

Comment 3 Caspar D.

2010-08-08 23:36:42 EDT

Committed to HEAD

Comment 4 Eike Stepper

2011-06-23 03:39:04 EDT

Available in R20110608-1407