Bugzilla – Full Text Bug Listing
| Summary: | [performance] QuickFixCreateField is very slow | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc-André Laperle <malaperle> | ||||
| Component: | cdt-codan | Assignee: | Elena Laskavaia <elaskavaia.cdt> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Elena Laskavaia <elaskavaia.cdt> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | cdtdoug, kosashi | ||||
| Version: | 8.0 | ||||||
| Target Milestone: | 8.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hi Alena, can you take a look at this simple patch? This quick fix performs poorly in its current state. Thanks! patch applied on head, thanks *** cdt cvs genie on behalf of elaskavaia *** Bug 321437 - passing a null index as the effect of not skipping any headers. Patch from Marc-Andre Laperle [*] QuickFixCreateField.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.checkers.ui/src/org/eclipse/cdt/codan/internal/checkers/ui/quickfix/QuickFixCreateField.java?root=Tools_Project&r1=1.2&r2=1.3 [*] CxxAstUtils.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core.cxx/src/org/eclipse/cdt/codan/core/cxx/CxxAstUtils.java?root=Tools_Project&r1=1.7&r2=1.8 |
Created attachment 175656 [details] Pass a non-null index to skip indexed headers QuickFixCreateField doesn't scale well when you have includes. It spends much of its time parsing code to build ASTs. See: IASTTranslationUnit ast = getTranslationUnitViaEditor(marker) .getAST(null, ITranslationUnit.AST_SKIP_INDEXED_HEADERS); passing a null index as the effect of not skipping any headers.