Bug 321378

Description Philipp Leusmann 2010-07-30 12:34:53 EDT

Build Identifier: 

When a BrowserFunction returns an empty array, org.eclipse.swt.internal.browser.browserkit.BrowserLCA.toJson(Object, boolean) encodes it as "][".

as a patch, the concerned if-block in said method could be:

else if (object.getClass().isArray())
        {
            Object[] array = (Object[]) object;
            result.append("[");
            for (int i = 0; i < array.length; i++)
            {
                result.append(toJson(array[i], false));
            }
            if (',' == result.charAt(result.length() - 1))
            {
                // insert ']' before last ','
                result.insert(result.length() - 1, "]");
            }
            else
            {
                // special handling for empty array
                result.append("],");
            }
        }


Also there are two related topics:

1) The method does not handle collections. An adequate addition would be

else if (object instanceof Collection)
        {
            result.append(toJson(((Collection) object).toArray(), false));
        }

2) What is the deleteLastChar-argument good for? Wouldn't it be sufficient to check, if the last character of the returned string is ',' and remove it, if needed?

Reproducible: Always